-
Notifications
You must be signed in to change notification settings - Fork 736
iscan for column tables #28847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iscan for column tables #28847
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
🟢 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Vladilen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хотелось бы диаграмму последовательности что где куда зачем ходит.
Смотрел на вики, там только верхнеуровнево
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -1,4 +1,4 @@ | |||
| #include "export.h" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А этот файл почему не удалил? Теперь у нас export.{h,cpp} в двух местах.
| static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns, | ||
| const NKikimrSchemeOp::TPathDescription& pathDesc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns, | |
| const NKikimrSchemeOp::TPathDescription& pathDesc) { | |
| static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme( | |
| const TMap<ui32, TUserTable::TUserColumn>& columns, | |
| const NKikimrSchemeOp::TPathDescription& pathDesc) | |
| { |
| static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns, | ||
| const NKikimrSchemeOp::TPathDescription& pathDesc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns, | |
| const NKikimrSchemeOp::TPathDescription& pathDesc) { | |
| static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme( | |
| const TMap<ui32, TUserTable::TUserColumn>& columns, | |
| const NKikimrSchemeOp::TPathDescription& pathDesc) | |
| { |
Changelog entry
...
Changelog category
Description for reviewers
...