Skip to content

Conversation

@dorooleg
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings November 13, 2025 17:23
@dorooleg dorooleg requested review from a team as code owners November 13, 2025 17:23
@github-actions

This comment was marked as outdated.

Copilot finished reviewing on behalf of dorooleg November 13, 2025 17:26
@github-actions
Copy link

🟢 2025-11-13 17:26:43 UTC The validation of the Pull Request description is successful.

@github-actions

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

Copy link
Collaborator

@Vladilen Vladilen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хотелось бы диаграмму последовательности что где куда зачем ходит.
Смотрел на вики, там только верхнеуровнево

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@dorooleg dorooleg requested a review from Vladilen November 17, 2025 13:25
@dorooleg dorooleg enabled auto-merge (squash) November 17, 2025 13:28
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

2025-11-17 13:29:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for c6dfe31 has started.
2025-11-17 13:30:06 UTC Artifacts will be uploaded here
2025-11-17 13:32:24 UTC ya make is running...
🟡 2025-11-17 15:01:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39553 36681 0 2 2840 30

2025-11-17 15:02:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-17 15:13:18 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 47 0 0 0 16

🟢 2025-11-17 15:13:26 UTC Build successful.
🟢 2025-11-17 15:13:50 UTC ydbd size 2.3 GiB changed* by +9.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f17740a merge: c6dfe31 diff diff %
ydbd size 2 480 218 576 Bytes 2 480 227 848 Bytes +9.1 KiB +0.000%
ydbd stripped size 520 979 160 Bytes 520 985 560 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

2025-11-17 13:30:14 UTC Pre-commit check linux-x86_64-release-asan for c6dfe31 has started.
2025-11-17 13:30:30 UTC Artifacts will be uploaded here
2025-11-17 13:32:47 UTC ya make is running...
🟡 2025-11-17 15:28:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15883 15477 0 146 233 27

🟢 2025-11-17 15:28:56 UTC Build successful.
🟢 2025-11-17 15:29:23 UTC ydbd size 3.9 GiB changed* by +272 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f17740a merge: c6dfe31 diff diff %
ydbd size 4 137 169 192 Bytes 4 137 169 464 Bytes +272 Bytes +0.000%
ydbd stripped size 1 523 014 144 Bytes 1 523 011 728 Bytes -2.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg merged commit 57cd43a into ydb-platform:main Nov 17, 2025
10 checks passed
@dorooleg dorooleg deleted the iscan branch November 17, 2025 15:29
@@ -1,4 +1,4 @@
#include "export.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А этот файл почему не удалил? Теперь у нас export.{h,cpp} в двух местах.

Comment on lines +27 to +28
static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
static TMaybe<Ydb::Table::CreateTableRequest> GenRowTableScheme(
const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc)
{

Comment on lines +71 to +72
static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc) {
static TMaybe<Ydb::Table::CreateTableRequest> GenColumnTableScheme(
const TMap<ui32, TUserTable::TUserColumn>& columns,
const NKikimrSchemeOp::TPathDescription& pathDesc)
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants