Skip to content

server: authorize voice http bind - #950

Merged
yisding merged 2 commits into
agent/ws51-webrtc-transport-authorized-bindfrom
agent/ws51-voice-http-authorized-bind
Aug 7, 2026
Merged

server: authorize voice http bind#950
yisding merged 2 commits into
agent/ws51-webrtc-transport-authorized-bindfrom
agent/ws51-voice-http-authorized-bind

Conversation

@yisding

@yisding yisding commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Problem

VoiceServer's retained aiohttp listener relied on a guard earlier in the larger startup transaction. That separation allowed a later refactor to move TCPSite construction away from the validation that authorizes it.

Change

  • retain the existing early process-level bind guard and its exception ordering
  • route TCPSite construction and start() through the shared authorized_bind capability
  • preserve partial-site ownership, rollback ordering, and exact backend exceptions
  • add lifecycle proofs that rejected authorization cannot construct the site and backend failures clean up the partial listener unchanged
  • reclassify only the VoiceServer HTTP site in the bind inventory (5 authorized, 4 pending)

Test evidence

  • env UV_FROZEN=1 uv run pytest tests/server/test_voice_server_lifecycle.py tests/server/test_auth.py tests/ratchets/test_bind_inventory.py -q — 70 passed, 4 skipped
  • env UV_FROZEN=1 uv run pytest tests/config/test_secret_reprs.py tests/server/test_auth.py tests/transports/test_webrtc_auth_browser_playground.py -q — 74 passed, 3 skipped
  • env UV_FROZEN=1 just check — pre-commit and mypy passed; 8,609 passed, 309 skipped

Stacked on #949.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 59504326-d3eb-4ff1-897e-d6a7c529a357

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yisding
yisding marked this pull request as ready for review August 7, 2026 02:47
@yisding
yisding force-pushed the agent/ws51-voice-http-authorized-bind branch from fde6d80 to 25e9e06 Compare August 7, 2026 03:35
@yisding
yisding force-pushed the agent/ws51-voice-http-authorized-bind branch from 25e9e06 to 161662c Compare August 7, 2026 03:50
@yisding
yisding merged commit a4a3fa1 into agent/ws14-twilio-connection-epoch Aug 7, 2026
2 checks passed
@yisding
yisding deleted the agent/ws51-voice-http-authorized-bind branch August 7, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant