server: authorize voice websocket bind - #951
Merged
yisding merged 2 commits intoAug 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yisding
marked this pull request as ready for review
August 7, 2026 02:47
yisding
force-pushed
the
agent/ws51-voice-websocket-authorized-bind
branch
from
August 7, 2026 03:37
5bdcdae to
91ad0f5
Compare
yisding
force-pushed
the
agent/ws51-voice-websocket-authorized-bind
branch
from
August 7, 2026 03:50
91ad0f5 to
4df0505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VoiceServer's raw-WebSocket listener relied on an earlier process-level guard rather than carrying authorization at the
websockets.servecapability boundary. A future startup refactor could therefore separate validation from the socket-opening backend call.Change
websockets.serveonly through the deferred binder passed toauthorized_bindTest evidence
env UV_FROZEN=1 uv run pytest tests/server/test_voice_server_lifecycle.py tests/server/test_auth.py tests/ratchets/test_bind_inventory.py -q— 72 passed, 4 skippedenv UV_FROZEN=1 uv run pytest tests/config/test_secret_reprs.py tests/server/test_auth.py tests/transports/test_webrtc_auth_browser_playground.py -q— 74 passed, 3 skippedenv UV_FROZEN=1 just check— pre-commit and mypy passed; 8,611 passed, 309 skippedStacked on #950.