Use current() to access first row.#76
Closed
enboig wants to merge 72 commits intoyllen:masterfrom
enboig:master
Closed
Use current() to access first row.#76enboig wants to merge 72 commits intoyllen:masterfrom enboig:master
enboig wants to merge 72 commits intoyllen:masterfrom
enboig:master
Conversation
To access database iterator first result, you should use `current()` and not `next()`. https://forum.glpi-project.org/viewtopic.php?id=283925
GitHub action
Co-authored-by: stonebuzz <7335054+stonebuzz@users.noreply.github.com>
* Update setup.php Co-authored-by: Stanislas <skita@teclib.com> * Create README.md * Remove config from readme * Fix setup.php * Fix setup.php --------- Co-authored-by: Stanislas <skita@teclib.com>
3 tasks
* Fix itilsolution picture visibility * Fix Lints
* Fix ticket task picture visibility * Fix Lints
Replace next() by current() to access first row
Fix By visible
Update PR template
Fix display when otherserial is null
Feat(repo): add missing CHANGELOG.md file
* Load logo from Branding when activated * Remove ReflectionClass method * Add toggle in config to enable Branding logo use * In english please * Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Stanislas <skita@teclib.com> * Drop support of old GLPI version for logo * Use hook for Branding logo * Use twig for config * Fix cs fixer * Fix headers * Update inc/simplepdf.class.php Co-authored-by: Stanislas <skita@teclib.com> * Update inc/simplepdf.class.php Co-authored-by: Stanislas <skita@teclib.com> --------- Co-authored-by: Stanislas <skita@teclib.com>
phpstan level 0
Phpstan level 5
Feat(CI): TwigCS
fix(export): resolve blank page issue on PDF export
Fix: front/ check
fix(export): images missing in exported Knowledge Base PDF
* Cast value to float, fixes "must be of type float, string given" when printing pdf with a currency-related value * Apply suggestions from code review --------- Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating my glpi modules I found
next()is used to access first row in iterators. It has changed in recent GPLI versions:https://forum.glpi-project.org/viewtopic.php?id=283925
I don't know if it would break installation on older GPLI 10.0.9