Promote the latest Cursor models in the picker - #937
Conversation
The Cursor default model list was stale, so Grok 4.5, GPT-5.6 Sol, and Opus 5 were hidden under "More models". Reorder `primaryModels` to put the latest families first. The ids are family ids (the default variant's raw id), not raw variant ids. The catalog folds reasoning effort and the `-fast` tail into one entry per family. I verified each id against real `agent --list-models` output through `parseAgentModelLines` + `buildAgentModelCatalog`. Fixes #933 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🚨 SLOP COP 🚨 · I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and end-to-end behavior. |
|
🚨 SLOP COP 🚨 · Security review complete. I found no security issues. The model identifiers remain constant argv values without shell interpretation. |
|
🚨 SLOP COP 🚨 · Performance review complete. I found no performance issue. The picker still processes 32 families and only moves one row between lists. |
|
🚨 SLOP COP 🚨 · Code-quality and architecture review complete. Every new identifier matches the Cursor catalog. I found one blocking host-daemon update issue. |
| selectFlag: "--model", | ||
| // Family ids (the default variant's raw id), not raw variant ids: the | ||
| // catalog folds effort and the `-fast` tail into one entry per family. | ||
| primaryModels: [ |
There was a problem hiding this comment.
🚨 slopcop/review — Increase the host daemon protocol version.
This list controls provider.list_models inside the host daemon. The server does not send a launch spec for built-in ACP providers.
An enrolled daemon with protocol 69 will keep the old list after the server deploys this commit. The unchanged protocol will not trigger the daemon update.
Increase HOST_DAEMON_PROTOCOL_VERSION and its contract expectation. This change will make each enrolled daemon receive the new list.
`packages/plugin-registry/r/icon.json` and `utils.json` changed in #888, but `plugin-starter-files.generated.ts` was not regenerated. The `@bb/templates` test runs the generator with `--check`, so CI fails on every branch that misses the Turbo cache. This is the mechanical output of `node packages/templates/scripts/generate-templates.mjs`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🚨 SLOP COP 🚨 · End-to-end review complete. The dev browser opened the Cursor picker. A local A direct host-daemon run with The agent-runtime typecheck passed. All 808 agent-runtime tests passed. |
SawyerHood
left a comment
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
One blocking issue requires a change.
The host daemon owns this built-in Cursor policy. The server does not send the built-in launch spec to enrolled daemons.
Without a protocol version increase, connected protocol-69 daemons keep the old primary list. Increase HOST_DAEMON_PROTOCOL_VERSION and its contract expectation.
The security review found no issue. The performance review found no issue.
The real Cursor catalog returned all six requested primary rows. The agent-runtime typecheck and all 808 agent-runtime tests passed.
The dev browser opened the Cursor picker. A local executable name conflict prevented a complete UI catalog check.
The pull request head later added one generated template update. That update did not change the reviewed Cursor code or this finding.
1 participant
Summary
The Cursor default model list in
ACP_AGENT_PROFILESwas stale. Grok 4.5, GPT-5.6 Sol, and Opus 5 were hidden under "More models". This reordersprimaryModelsto put the latest families first.New order:
auto, Cursor Grok 4.5, GPT-5.6 Sol, Opus 5, Fable 5, Composer 2.5.Opus 4.8 and GPT-5.5 move into "More models". They stay selectable.
Notes
primaryModelsmatches family ids — the raw id of the family's default variant — not raw variant ids. The catalog folds reasoning effort and the-fasttail into one entry per family, so the-fastids from the issue need no separate entries. A wrong id makes an entry vanish, and an all-miss list silently falls back to the full picker.I verified every id by running real
agent --list-modelsoutput throughparseAgentModelLines+buildAgentModelCatalog. All 6 match a real family.Tests
pnpm exec turbo run typecheck test --filter=@bb/agent-runtime— 808 tests passed.Fixes #933
🤖 Generated with Claude Code