Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamically configure PID controller gains #249

Closed
corot opened this issue Apr 11, 2013 · 14 comments
Closed

Allow dynamically configure PID controller gains #249

corot opened this issue Apr 11, 2013 · 14 comments

Comments

@corot
Copy link
Collaborator

corot commented Apr 11, 2013

We need to change firmware, driver and node.

Don't forget a huge warning in the doc to prevent beginners to play with this!

@bit-pirate
Copy link
Contributor

Why do we need this? Did you experience issues with varying loads?

@corot
Copy link
Collaborator Author

corot commented May 22, 2013

Was a Bill's suggestion. We don't need it by now, really. But is a nice feature for advanced users. For example to climb slopes, haul heavy loads or simply customize robot operation.

@corot
Copy link
Collaborator Author

corot commented May 22, 2013

Btw, my robot provides it and is much crappier than kobuki!

@bit-pirate
Copy link
Contributor

Are you trying to tease us?

2013/5/22 corot notifications@github.com

Btw, my robot provides it and is much crappier than kobuki!

Reply to this email directly or view it on GitHubhttps://github.com//issues/249#issuecomment-18258823
.

Marcus Liebhardt
Adresse: Zimmer 403, 634-1 Seongsan-dong, Mapo-gu, 121-846, Seoul, Republik
Korea
Address: Room 403, 634-1 Seongsan-dong, Mapo-gu, 121-846, Seoul, Republic
of Korea
주소: 대한민국 서울특별시 121-846 마포구 634-1 성산동 4 층 403 호
Mobile / Mobilfunk: +82 10 3322 0566
Email: ich@marcusliebhardt.de ich@marcusliebhardt.de

@stonier
Copy link
Member

stonier commented Aug 20, 2013

Another idea, have split pid's in the robot, on for low speeds, another for high speeds.

Actually maybe not such a great idea, it's the payload that causes the problems. PID's for kobuki are currently well tuned, for turtlebot not.

@stonier
Copy link
Member

stonier commented Aug 20, 2013

Target:

  • Just put the mechanism there, let's not worry about tuning it until we really need it (jprobably next rocon demo)
  • Einstein - firmware
  • Young Hoon - sofware driver and ros node parameters (needs defaults and parameter validation).

@yhju
Copy link
Contributor

yhju commented Aug 29, 2013

updating firmware protocol documentation remains.

@yhju yhju reopened this Aug 29, 2013
@corot
Copy link
Collaborator Author

corot commented Aug 29, 2013

Also we need to check that firmware's minor version is >= 2. If not, show a warning with the Kobuki firmware updates URL.

if (firmware.check_minor_version() < 0) ....

@corot
Copy link
Collaborator Author

corot commented Aug 29, 2013

And add the same message in the wiki!

yhju added a commit to yhju/kobuki that referenced this issue Aug 29, 2013
stonier added a commit that referenced this issue Aug 29, 2013
Updated doxygen script and firmware specification about custom pid gain setting. Issue #249.
@stonier
Copy link
Member

stonier commented Aug 29, 2013

Also add notes on the wiki and in the doxygen specifying what the default values are so people have a reference point for experimentation.

@yhju
Copy link
Contributor

yhju commented Aug 29, 2013

Factory default value of PID gains added on doxygen by 3a0bf5e.
ROS wiki is not editable yet.

@yhju
Copy link
Contributor

yhju commented Aug 29, 2013

Version of updated firmware is 1.2.0. It is not released yet on http://files.yujinrobot.com/kobuki/firmware.

@yhju
Copy link
Contributor

yhju commented Aug 30, 2013

firmware released, changelog also updated.

@yhju
Copy link
Contributor

yhju commented Aug 30, 2013

roswiki also updated on http://wiki.ros.osuosl.org/kobuki_node/hydro

@yhju yhju closed this as completed Aug 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants