Skip to content

feat: add-mise-tools - #806

Merged
yxtay merged 3 commits into
mainfrom
feat/add-mise-tools
Jun 8, 2026
Merged

feat: add-mise-tools#806
yxtay merged 3 commits into
mainfrom
feat/add-mise-tools

Conversation

@yxtay

@yxtay yxtay commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Pinned development tool runtimes: Java 17 and Node (LTS).
    • Broadened ignore pattern to exclude megalinter report files.
    • Adjusted linting/security scan configuration: disabled a Terraform scanner and updated scanner/reporting arguments and environment handling.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd0c2e48-57f2-4c9e-8c25-e4b4121c4c77

📥 Commits

Reviewing files that changed from the base of the PR and between 5692094 and 25f447a.

📒 Files selected for processing (2)
  • .gitignore
  • .mega-linter.yml

📝 Walkthrough

Walkthrough

Adds a [tools] block to mise config to pin Java and Node versions, broadens the .gitignore pattern for megalinter-reports, and updates .mega-linter.yml to disable TERRAFORM_TERRASCAN plus adjust scanner arguments, SARIF output, and a Terraform env allowlist.

Changes

Mise Tool Runtime Versions

Layer / File(s) Summary
Tool runtime version pinning
chezmoi/private_dot_config/mise/config.toml
Adds a [tools] section specifying java = "17" and node = "lts".

MegaLinter & Ignore Adjustments

Layer / File(s) Summary
Disable TERRAFORM_TERRASCAN
.mega-linter.yml
Adds TERRAFORM_TERRASCAN to DISABLE_LINTERS.
Linter arguments, SARIF, Terraform env allowlist, and ignore pattern
.mega-linter.yml, .gitignore
Updates repository scanner arguments (including REPOSITORY_DEVSKIM_ARGUMENTS), enables SARIF output, adds TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES containing GITHUB_TOKEN, and changes .gitignore entry from megalinter-reports/ to megalinter-reports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny patch hopped by tonight,
Pins Java and Node so versions sit tight,
Linters take a pause, reports tucked away,
Configs whisper softly: "run another day",
Dotfiles neat, the rabbit hops off light. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add-mise-tools' directly describes the main change: adding mise tools configuration with pinned Java and Node versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-mise-tools

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a mise configuration file (config.toml) to manage Java 17 and Node.js LTS. The review feedback highlights a potential conflict where Node.js is managed by both mise and Homebrew, which could cause PATH conflicts, and suggests removing Node.js from the Homebrew bundle.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -0,0 +1,3 @@
[tools]
java = "17"
node = "lts"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Installing Node.js via both mise (node = "lts") and Homebrew (brew "node" in run_before_brew_install.sh.tmpl) can lead to PATH conflicts and unexpected version resolution depending on shell initialization order. It is recommended to remove node from your Homebrew bundle so that mise solely manages your Node.js versions.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ BASH shfmt 3 0 0 0 0.02s
✅ JSON prettier 1 0 0 0 0.42s
✅ MARKDOWN markdownlint 4 0 0 0 0.65s
✅ MARKDOWN markdown-table-formatter 4 0 0 0 0.16s
✅ YAML prettier 10 0 0 0 0.56s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters BASH_SHFMT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,YAML_PRETTIER

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@yxtay
yxtay merged commit 2dd8cbd into main Jun 8, 2026
13 of 16 checks passed
@yxtay
yxtay deleted the feat/add-mise-tools branch June 8, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant