Skip to content

chore: remove mise npm - #820

Merged
yxtay merged 1 commit into
mainfrom
chore/remove-mise-npm-edge
Jun 12, 2026
Merged

chore: remove mise npm#820
yxtay merged 1 commit into
mainfrom
chore/remove-mise-npm-edge

Conversation

@yxtay

@yxtay yxtay commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Chores

  • Microsoft Edge Homebrew installation is now disabled; users requiring this browser must install it manually
  • Agent plugin npm package installation process has been updated with a new installation method
  • Development toolchain configuration has been updated: Java 17 is now configured and available; Node.js LTS has been removed from automatic installation

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 96a9cad1-1550-4702-b572-1ac12261d79e

📥 Commits

Reviewing files that changed from the base of the PR and between 9de87d9 and e31ee5d.

📒 Files selected for processing (3)
  • chezmoi/.chezmoiscripts/run_before_brew_install.sh.tmpl
  • chezmoi/.chezmoiscripts/run_onchange_after_agent_plugins.sh.tmpl
  • chezmoi/private_dot_config/mise/config.toml

📝 Walkthrough

Walkthrough

Three dotfiles configuration scripts are updated: Homebrew cask setup disables microsoft-edge installation and adjusts comment formatting; plugin setup changes codegraph installation to npx and simplifies rtk initialization; and mise configuration removes the node runtime and adds Java 17.

Changes

Environment and Tooling Configuration

Layer / File(s) Summary
Homebrew cask configuration
chezmoi/.chezmoiscripts/run_before_brew_install.sh.tmpl
The microsoft-edge cask is commented out with a note about requiring sudo, while microsoft-auto-update remains installed with adjusted comment formatting.
Plugin and codegraph installation setup
chezmoi/.chezmoiscripts/run_onchange_after_agent_plugins.sh.tmpl
Global codegraph installation switches from npm install --global to npx --yes with additional argument flags; rtk init command for opencode loses --auto-patch --hook-only options.
Tool version configuration
chezmoi/private_dot_config/mise/config.toml
Mise [tools] section removes node = "lts" and adds java = "17".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/S, chore

Poem

🐰 A brew cask steps aside with grace,
CodeGraph finds a swifter place,
Java now stands tall at seventeen—
The finest dotfiles ever seen!
Small tweaks compose a symphony sweet.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-mise-npm-edge

Comment @coderabbitai help to get the list of available commands and usage tips.

@yxtay
yxtay merged commit e64556d into main Jun 12, 2026
17 of 19 checks passed
@yxtay
yxtay deleted the chore/remove-mise-npm-edge branch June 12, 2026 07:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request comments out the Microsoft Edge cask in Homebrew, simplifies the installation of the @colbymchenry/codegraph package, removes Node.js from the mise configuration, and removes the --auto-patch and --hook-only flags from the rtk init command. The reviewer advises against removing these flags from rtk init because doing so could cause the command to run interactively and block non-interactive chezmoi apply executions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

fi
if command -v opencode >/dev/null; then
rtk init --global --opencode --auto-patch --hook-only;
rtk init --global --opencode;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the --auto-patch and --hook-only flags may cause rtk init to run interactively or perform a full initialization, which can block or fail during non-interactive chezmoi apply runs. It is recommended to keep these flags to maintain non-interactive execution.

    rtk init --global --opencode --auto-patch --hook-only;

This was referenced Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant