chore: remove mise npm - #820
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree dotfiles configuration scripts are updated: Homebrew cask setup disables microsoft-edge installation and adjusts comment formatting; plugin setup changes codegraph installation to npx and simplifies rtk initialization; and mise configuration removes the node runtime and adds Java 17. ChangesEnvironment and Tooling Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request comments out the Microsoft Edge cask in Homebrew, simplifies the installation of the @colbymchenry/codegraph package, removes Node.js from the mise configuration, and removes the --auto-patch and --hook-only flags from the rtk init command. The reviewer advises against removing these flags from rtk init because doing so could cause the command to run interactively and block non-interactive chezmoi apply executions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| fi | ||
| if command -v opencode >/dev/null; then | ||
| rtk init --global --opencode --auto-patch --hook-only; | ||
| rtk init --global --opencode; |
There was a problem hiding this comment.
Removing the --auto-patch and --hook-only flags may cause rtk init to run interactively or perform a full initialization, which can block or fail during non-interactive chezmoi apply runs. It is recommended to keep these flags to maintain non-interactive execution.
rtk init --global --opencode --auto-patch --hook-only;
Summary by CodeRabbit
Chores