-
-
Notifications
You must be signed in to change notification settings - Fork 758
reports: Caps fixed for Section Selections of the Report Generation Template #6095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Hello ZAP team! I am a new contributor and desiring to grow my knowledge about the ZAP code base to provide more significant contributions in the future. I decided to start with fixing title caps as mentioned in issue 2000. I am certain what Messages.properties to change as I have submitted here. "./gradlew run" on zaproxy project doesn't reflect the changes made. Could you point me to the documentation on how to test my changes? |
|
I have read the CLA Document and I hereby sign the CLA |
|
Great job, no security vulnerabilities found in this Pull Request |
|
If you run ZAP then press ctrl + l (that's an L) then navigate to the build location (something like: |
|
The CHANGELOG: https://github.com/zaproxy/zap-extensions/blob/main/addOns/reports/CHANGELOG.md should also be updated. In the "Unreleased" section add a |
|
I've done the CHANGELOG as well. I wasn't convinced that this was a significant change for the CHANGELOG but there, added it now. Thanks @kingthorin . |
|
Ensure you provide the right API key or disable it. |
|
Hi, @kingthorin , @thc202 Just checking if I am still missing anything for this change to be approved. |
|
It just needs a second review. The changelog is a bit verbose but 🤷♂️ |
|
It needs two reviews not just one. |
addOns/reports/src/main/zapHomeFiles/reports/risk-confidence-html/Messages.properties
Outdated
Show resolved
Hide resolved
aa15a3c to
2224ab3
Compare
Signed-off-by: bj-taduran <bj.taduran@gmail.com>
|
Thank you both! |


Overview
What: Attempted to fix title caps.

Where: Zap App > Report (menu bar) > Generate Report > Template > Sections