Skip to content

Conversation

@bj-taduran
Copy link
Contributor

Overview

What: Attempted to fix title caps.
Where: Zap App > Report (menu bar) > Generate Report > Template > Sections
Selection_007

@github-actions
Copy link

github-actions bot commented Jan 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@bj-taduran
Copy link
Contributor Author

bj-taduran commented Jan 14, 2025

Hello ZAP team!

I am a new contributor and desiring to grow my knowledge about the ZAP code base to provide more significant contributions in the future. I decided to start with fixing title caps as mentioned in issue 2000.

I am certain what Messages.properties to change as I have submitted here.
However, after building zap-extension through "./gradlew addOns:reports:copyZapAddOn"
and building zaproxy "./gradlew build"

"./gradlew run" on zaproxy project doesn't reflect the changes made.

Could you point me to the documentation on how to test my changes?

@bj-taduran
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@psiinon
Copy link
Member

psiinon commented Jan 14, 2025

Logo
Checkmarx One – Scan Summary & Details3cc0d2d2-5beb-47a8-8869-025f2463641e

Great job, no security vulnerabilities found in this Pull Request

@kingthorin
Copy link
Member

kingthorin commented Jan 14, 2025

If you run ZAP then press ctrl + l (that's an L) then navigate to the build location (something like: C:\Users\user\Desktop\zap-ws\zap-extensions\addOns\reports\build\zapAddOn\bin ) you can select the newly built add-on and load it.
(In you may need to close and re-launch ZAP in order to see the changes, after having loaded the add-on).

@kingthorin
Copy link
Member

The CHANGELOG: https://github.com/zaproxy/zap-extensions/blob/main/addOns/reports/CHANGELOG.md should also be updated. In the "Unreleased" section add a ### Changed heading and a bullet that describes the change and references the issue (just read older entries for inspiration).

@bj-taduran
Copy link
Contributor Author

Selection_010
Seeing that through was so satisfying. I earlier tried ./gradlew addOns:reports:install --port 8080 but it was giving SocketException error. Ctrl+L was a nifty tip.

I've done the CHANGELOG as well. I wasn't convinced that this was a significant change for the CHANGELOG but there, added it now.

Thanks @kingthorin .

@thc202 thc202 changed the title Caps fixed for Section Selections of the Report Generation Template reports: Caps fixed for Section Selections of the Report Generation Template Jan 15, 2025
@thc202
Copy link
Member

thc202 commented Jan 15, 2025

#6095 (comment)

Ensure you provide the right API key or disable it.

@bj-taduran
Copy link
Contributor Author

bj-taduran commented Jan 16, 2025

Hi, @kingthorin , @thc202

Just checking if I am still missing anything for this change to be approved.
The API key is for testing the change, right? Or did I misunderstand something?

@kingthorin
Copy link
Member

It just needs a second review. The changelog is a bit verbose but 🤷‍♂️

@thc202
Copy link
Member

thc202 commented Feb 4, 2025

It needs two reviews not just one.

kingthorin pushed a commit to kingthorin/cla that referenced this pull request Mar 13, 2025
@kingthorin kingthorin self-assigned this Jun 13, 2025
@kingthorin kingthorin force-pushed the main branch 4 times, most recently from aa15a3c to 2224ab3 Compare June 13, 2025 15:20
Signed-off-by: bj-taduran <bj.taduran@gmail.com>
@thc202
Copy link
Member

thc202 commented Jun 19, 2025

Thank you both!

@psiinon psiinon merged commit 39e5735 into zaproxy:main Jun 19, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants