mr_list: Support search

[fmuellner]

Search is as useful for merge requests as for issues, so support
the same option as lab issue list.

[codecov]

Codecov Report

Merging #560 (8251fd6) into master (7c2c165) will decrease coverage by 0.05%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   58.30%   58.25%   -0.06%     
==========================================
  Files          64       64              
  Lines        4197     4211      +14     
==========================================
+ Hits         2447     2453       +6     
- Misses       1516     1522       +6     
- Partials      234      236       +2     

Impacted Files	Coverage Δ
cmd/issue_list.go	78.94% <42.85%> (-5.06%)	⬇️
cmd/mr_list.go	72.34% <50.00%> (-2.38%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2c165...8251fd6. Read the comment docs.

[bmeneg]

@fmuellner do you think it would be useful a "--full-match" flag for adding double-quotes in the terms and forcing that "exact" (it still is case insensitive) match?
It would basically be the same as lab issue search "\"search terms\"".

[fmuellner]

do you think it would be useful a "--full-match" flag for adding double-quotes in the terms and forcing that "exact" (it still is case insensitive) match?
It would basically be the same as lab issue search "\"search terms\"".

Do you mean to both lab mr list and lab issue list? IMHO those two commands should be as consistent as possible.

That said, a flag does sound more convenient than escaping quotes on the command line. I'd prefer --exact-match over --full-match though - the latter suggests something like full-text search (i.e. searching comments as well) to me.

[bmeneg]

do you think it would be useful a "--full-match" flag for adding double-quotes in the terms and forcing that "exact" (it still is case insensitive) match?
It would basically be the same as lab issue search "\"search terms\"".

Do you mean to both lab mr list and lab issue list? IMHO those two commands should be as consistent as possible.

Yes! Sorry. It must be for both :)

That said, a flag does sound more convenient than escaping quotes on the command line. I'd prefer --exact-match over --full-match though - the latter suggests something like full-text search (i.e. searching comments as well) to me.

Hmm, although I agree with your concern with --full-match, I also think --exact-match is somewhat misleading, since it gives the impression of a case-sensitive search, which is not. What about only --match ?

[fmuellner]

What about only --match ?

Maybe as a string flag (lab issue list --match="foo bar" instead of lab issue list "foo bar" - but then what about lab issue list --match="foo bar" baz?). For a boolean, the name sounds too generic to me.

I also think --exact-match is somewhat misleading, since it gives the impression of a case-sensitive search

Right, that's a concern.

OTOH, both Google and DuckDuckGo use "exact match/term":
https://support.google.com/websearch/answer/2466433?hl=en
https://help.duckduckgo.com/duckduckgo-help-pages/results/syntax/

And in both cases, the search is case insensitive (in fact, searching for "cats and dogs" turns up "Cats & Dogs" as top result in both for me)

[bmeneg]

What about only --match ?

Maybe as a string flag (lab issue list --match="foo bar" instead of lab issue list "foo bar" - but then what about lab issue list --match="foo bar" baz?). For a boolean, the name sounds too generic to me.

Yeah.. using it as a string would be confusing.

I also think --exact-match is somewhat misleading, since it gives the impression of a case-sensitive search

Right, that's a concern.

OTOH, both Google and DuckDuckGo use "exact match/term":
https://support.google.com/websearch/answer/2466433?hl=en
https://help.duckduckgo.com/duckduckgo-help-pages/results/syntax/

And in both cases, the search is case insensitive (in fact, searching for "cats and dogs" turns up "Cats & Dogs" as top result in both for me)

Hmmm. let's use --exact-match then. However, if possible, let it clear that the search is case-insensitive in the flag description.

Thanks @fmuellner !

[prarit]

Hi, due to no fault of yours the lab test code was broken. I have fixed the tests in #575 and #573 . Can you please rebase to see if your build will past testing? My sincere apologies for the inconvenience.

[bmeneg]

LGTM