mr_list_test: mrListStateClosed fix#575
Merged
prarit merged 1 commit intozaquestion:masterfrom Jan 21, 2021
Merged
Conversation
mrListStateClosed test is failing with not finding the output "!5 closed mr". This occurs because the output contains only the first 20 closed MRs. If all the closed MRs were listed the test will pass. Modify the mrListStateClosed test to list all closed MRs. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Collaborator
Author
|
This fixes the remaining test failure. |
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
- Coverage 58.29% 58.20% -0.09%
==========================================
Files 63 64 +1
Lines 4134 4197 +63
==========================================
+ Hits 2410 2443 +33
- Misses 1489 1519 +30
Partials 235 235
Continue to review full report at Codecov.
|
This was referenced Jan 21, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrListStateClosed test is failing with not finding the output "!5 closed
mr". This occurs because the output contains only the first 20 closed
MRs. If all the closed MRs were listed the test will pass.
Modify the mrListStateClosed test to list all closed MRs.
Signed-off-by: Prarit Bhargava prarit@redhat.com