Check add GA to prevent adding dependencies to package.json #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zidmus
force-pushed
the
zidan/veg-1466/fix_prevent_dependencies_from_being_added
branch
3 times, most recently
from
064976c to
deb0dd3
Compare
Parse package.json using jq
zidmus
force-pushed
the
zidan/veg-1466/fix_prevent_dependencies_from_being_added
branch
from
592dab7 to
185ebd9
Compare
cl8au
approved these changes
Sep 12, 2022
Frederick888
approved these changes
Sep 13, 2022
|
This PR was deployed to Static Assets Build. Reference: v2.0.37 |
|
This PR was deployed to Static Assets Switch Staging. Reference: v2.0.37 |
|
This PR was deployed to Static Assets Switch Major (v2). Reference: v2.0.37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
Dependencies which pollute the global in javascript can cause conflicts with versions of libraries used by app developers within their apps. Therefore, to mitigate the risk of conflicts, we would like to identify a way to prevent dependencies from being added to ZAF_SDK unintentionally.
References
Risks
Rollback Plan