Skip to content

Check add GA to prevent adding dependencies to package.json #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Check add GA to prevent adding dependencies to package.json #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ jobs:
dependency-guard:
runs-on: ubuntu-latest
steps:
- uses: zendesk/checkout@v2
- name: Block dependencies from being added to package.json
run: |
IFS=' ' read -r allowed <<< "native-promise-only zendesk_app_framework_sdk"
dependencies=$(npm ls --production --depth=0 --parseable | awk '{gsub(/\/.*\//,"",$1); print}')

for dep in $dependencies; do
dependencies=$(jq -r .dependencies package.json | jq 'keys' | jq .[] | sed 's/"//g')
for dep in "${dependencies[@]}"; do
if [[ ! ${allowed[*]} =~ (^|[[:space:]])"$dep"($|[[:space:]]) ]]; then
echo "::error ZAP SDK does not allow external dependencies, please remove \"${dep}\" dependency from package.json"
exit 1
Expand Down