chore: replace "server" with "node"/"API" across the repo - #121
Merged
TaprootFreak merged 6 commits intoMay 26, 2026
Conversation
Aligns the prose, ASCII trees, and anchor links across CONTRIBUTING, README, ROADMAP, SPEC, MIGRATION_RESEARCH, BRIDGE_MVP, BITVM_BRIDGE, MULTI_ASSET, LIGHTNING_ATOMIC_SWAP, and ARKADE_INTEGRATION with the post-rename module names (node/src/router.rs, the zkCoins node, etc.). External components (Bitcoin Core, electrs/Esplora, Postgres) keep their proper names; bitcoind's server=1 flag and Docker volume zkcoins_node-data are corrected accordingly.
…r" references Updates doc-comments, migration notes, and historical planning records in program-plonky2 (CONTRIBUTING/SESSION_STATE/STEP4_REVIEW/STEP7_PREP plus the rustdoc on types.rs, merkle helpers, and circuit/main.rs), script-plonky2 (CONTRIBUTING + lib.rs rustdoc), and the shared commitment_tests module header to refer to the zkCoins node instead of the legacy "server" wording. No code logic changes.
Sweeps the remaining "server" prose in node/src/* and node/tests/* to match the post-rename crate identity. Renames three local Rust bindings whose names referenced the old crate: * minting_server_account -> minting_node_account (runtime.rs) * server_clone -> node_clone (router_tests.rs) * server_guard -> account_node_guard (router_tests.rs) Doc-comments and error/log messages on main.rs, router.rs, runtime.rs, scanner.rs, db.rs, account_node.rs, the matching test files, and node/tests/api_remote.rs now refer to "the node" or "the API" as appropriate. The env-var ZKCOINS_E2E_ALLOW_FEATURE_TRIMMED_SERVER is kept verbatim because it is a stable CI contract with deploy-dev.yaml. External names are untouched: StatusCode::INTERNAL_SERVER_ERROR, wiremock::MockServer + every mock_server/mint_broadcast_mock_server binding, scanner_ws_tests' spawn_ws_server (Esplora WS mock), and the bitcoind server=1 documentation example all keep their original spelling.
Replaces the remaining prose references to the legacy "server" name
in ci.yaml, deploy-dev.yaml, and deploy-prd.yaml — workflow_dispatch
descriptions, deploy-target labels ("deployed DEV/PRD server"),
test-target descriptions ("live-DEV-server verification"), and the
bootstrap-env comment all now refer to "the node" instead.
External names stay untouched: SSH ServerAlive*, github.server_url,
sccache --start-server / --stop-server, and the
ZKCOINS_E2E_ALLOW_FEATURE_TRIMMED_SERVER env-var contract with the
api_remote test macro all keep their original spelling.
TaprootFreak
marked this pull request as ready for review
May 26, 2026 21:12
…node Resolve conflict in runtime.rs (boot_log block from release branch kept, "REST server" → "REST API" rename applied). Apply server → node rename to merge-introduced files: - node/migrations/0006_inscription_kind.sql, 0007_request_log.sql, 0008_full_database_trail.sql - node/src/db.rs (4 doc-comments) - node/src/router.rs (1 doc-comment)
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final, comprehensive
server→node/APIrename pass across the whole repo. The repo was previously namedzk-coins/server; the termserverfor our own HTTP service is deprecated. Prior partial passes (#98, #101, #104) only touched docs — this PR covers the remaining residuals in source comments, code identifiers, CI workflows, and SQL migrations.Naming convention applied:
node= our zkCoins HTTP service (default).API= used when the HTTP interface is what's being discussed ("API endpoint", "REST API", "the API returns 400").Bitcoin Core/bitcoind= the Bitcoin daemon (replaces "Bitcoin server").electrs,Esplora,Postgres, sccache, SSH, GitHub Actions context,wiremock::MockServer,axum::serve,StatusCode::INTERNAL_SERVER_ERROR, etc.) are intentionally not renamed.ZKCOINS_E2E_ALLOW_FEATURE_TRIMMED_SERVERenv var keeps its_SERVERsuffix; a code comment explains why.Commits
a7231a168028dab53ee42minting_server_account→minting_node_account,server_clone→node_clone,server_guard→account_node_guard) + comments acrossnode/srcandnode/tests8ad972dce4307cNotes
CONTRIBUTING.mdcorrected:server/server.rs→node/router.rs(matches actual layout).zkcoins_server-data→zkcoins_node-data.MIGRATION_RESEARCH.md§7.23 heading renamed and all 3 cross-references inROADMAP.md/SPEC.mdupdated to match.Test plan
cargo fmt --all -- --checkcleancargo clippy --workspace --all-features --no-deps -- -D warningscleancargo check --workspace --all-featuresclean