hotfix(migrations): revert 0001 + 0003 comment edits to restore sqlx hash - #126
Closed
TaprootFreak wants to merge 1 commit into
Closed
hotfix(migrations): revert 0001 + 0003 comment edits to restore sqlx hash#126TaprootFreak wants to merge 1 commit into
TaprootFreak wants to merge 1 commit into
Conversation
…hash The DEV container has been crash-looping with Migrate(VersionMismatch(1)) since the develop merge (PR #117) brought in the comment edits from PR #122 (and earlier, PR #121's ce4307c). sqlx::migrate! hashes the FULL file content (including comments and whitespace) and panics on drift against _sqlx_migrations.checksum. Restore the byte-identical pre-rename content from 13155c1 (the prior hotfix for the same root cause on 0001) and b26a2d1 (for 0003). Per feedback_sqlx_migration_hash.md: future comment fixes must land in a follow-up migration, never in the versioned files themselves. 0006-0008 are not yet applied on DEV (DB only has 0001-0005), so their comment state is whatever ships first — the current "node" wording is fine going forward.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEV container crash-loop since PR #117 merge: `Migrate(VersionMismatch(1))` because comment edits to versioned migrations (from PR #121 and PR #122) changed the file SHA that sqlx::migrate! computes against `_sqlx_migrations.checksum` on the DEV DB.
This is the same failure mode as #95 — repeating because PR #121's `ce4307c` and the merge-resolution in PR #122 re-applied the cosmetic edits that #95 had undone.
Fix
Restore byte-identical pre-rename content for:
0002, 0004, 0005 were never touched. 0006–0008 are not yet applied on DEV (`_sqlx_migrations` only has rows 1–5), so their current `node` wording will become the locked-in hash when they first apply — no action needed.
Test plan
Follow-up
`feedback_sqlx_migration_hash.md` rule: never edit versioned migration content. Future renames or comment fixes go into a new migration file (`0099_fix_xy.sql`).