feat(relay): relay tell-invoked command output and Market's direct announcements - #58
Merged
Merged
Conversation
…nouncements Two gaps left by the previous relay_command_output() hook (PG-only), found via live testing on the mesh: - Commands run via /tell only ever set the TELL bit in output_destination(), never PG, so they never hit the relay hook. Consolidate the hook to fire once for either TELL or PG. - Market.php's announce()/announce_background() call send_pgroup() directly, bypassing output_destination() entirely. Hook both call sites the same way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
…PassiveModule find_source_file() looks for a file literally named "BasePassiveModule.php", but the real file is "00_BasePassiveModule.php" (numeric prefix), so it's never found and the generator emits an unlinked class name - correct the hand-edited README to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 4, 2026
zznathans
pushed a commit
that referenced
this pull request
Aug 4, 2026
This whole feature (relaying a bot's own command output/activity lines across the mesh, added across #56/#58, partially reverted in #60) turned out to be more scope and code-base churn than it was worth for what's actually needed. Fully removing it: - Modules/Relay.php: drop relay_command_output() and the Relay.RelayCommandOutput setting. - Modules/Ao/Market.php: announce()/announce_background() go back to their original single send_pgroup() call - local private-channel logging stays exactly as it was before any of this, just no longer relayed across bots. - Commodities/00_BasePassiveModule.php: drop the leftover explanatory comment from the #60 revert. - Tests/Stubs/FakeMarketBot.php, Tests/Stubs/FakeRelayBot.php, Tests/Modules/Ao/MarketTest.php, Tests/Modules/RelayTest.php, Tests/README.md: back to their pre-#56 state. Confirmed via `git diff` against the commit before #56 that every touched file is now byte-identical to its pre-feature state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relay_command_output()hook inoutput_destination()to fire for bothTELLandPGchannel replies (previously PG-only), so command output sent via/tellalso relays to the mesh hub.Market.php'sannounce()/announce_background(), which callsend_pgroup()directly and previously bypassedoutput_destination()entirely.Follow-up to #56, based on live testing on the production mesh: enabling
Relay.RelayCommandOutputand running!market statusinside a spoke bot's own group relayed correctly, but running it via/tellto that bot did not, and Market's own "X used market Y" activity-log line never relayed either.Test plan
Tests/Commodities/BasePassiveModuleTest.phpcovering TELL/PG/GC channel behavior and no-double-relay when both TELL and PG bits are set.Tests/Modules/Ao/MarketTest.phpcoveringannounce()/announce_background()relay gating.Tests/README.mdregenerated (by hand, no local PHP in this environment) to match./tella spoke bot a market command and confirm it relays to Beuroman; trigger a Market activity announcement and confirm it relays too.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com