fix(relay): remove the relay-command-output feature entirely - #63
Merged
Conversation
This whole feature (relaying a bot's own command output/activity lines across the mesh, added across #56/#58, partially reverted in #60) turned out to be more scope and code-base churn than it was worth for what's actually needed. Fully removing it: - Modules/Relay.php: drop relay_command_output() and the Relay.RelayCommandOutput setting. - Modules/Ao/Market.php: announce()/announce_background() go back to their original single send_pgroup() call - local private-channel logging stays exactly as it was before any of this, just no longer relayed across bots. - Commodities/00_BasePassiveModule.php: drop the leftover explanatory comment from the #60 revert. - Tests/Stubs/FakeMarketBot.php, Tests/Stubs/FakeRelayBot.php, Tests/Modules/Ao/MarketTest.php, Tests/Modules/RelayTest.php, Tests/README.md: back to their pre-#56 state. Confirmed via `git diff` against the commit before #56 that every touched file is now byte-identical to its pre-feature state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fully removes the relay-command-output feature added across #56/#58 and partially reverted in #60. Turned out to be more scope/complexity than warranted - local private-channel logging via
Market.php'sannounce()/announce_background()stays exactly as it was before any of this (that's the "logging to priv channel" behavior), it's just no longer relayed across the bot mesh.Verified via
git diffagainst the commit immediately before #56 that every touched file (Commodities/00_BasePassiveModule.php,Modules/Relay.php,Modules/Ao/Market.php, and the associated test files/stubs) is now byte-identical to its pre-feature state.Uses a
fix:commit type deliberately - the prior revert (#60) usedrevert:, which semantic-release's default rules don't treat as release-triggering, so it silently never shipped until a follow-upfix:commit forced it (#61).Test plan
git diffconfirms all touched files match their pre-feat(relay): relay a bot's own command output to the hub bot #56 state exactly.Market.LogToPrivateChannel/LogBackgroundToPrivateChannellogging still works as before.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com