revert(relay): stop relaying command reply content, keep Market's activity announcements - #60
Merged
Conversation
…ivity announcements output_destination()'s TELL/PG relay hook (added in #56, extended in #58) relayed the full text of every command reply across the mesh, which is noisier than wanted - especially since the majority of commands are run via tell directly to the hub bot. Revert that hook back to its pristine pre-#56 form. Market.php's own announce()/announce_background() relay hooks (added in this same follow-up, "X used market Y" activity-log lines) stay - that's the "command was run" signal that's actually wanted, and it already works correctly across the mesh. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
This was referenced Aug 4, 2026
zznathans
pushed a commit
that referenced
this pull request
Aug 4, 2026
This whole feature (relaying a bot's own command output/activity lines across the mesh, added across #56/#58, partially reverted in #60) turned out to be more scope and code-base churn than it was worth for what's actually needed. Fully removing it: - Modules/Relay.php: drop relay_command_output() and the Relay.RelayCommandOutput setting. - Modules/Ao/Market.php: announce()/announce_background() go back to their original single send_pgroup() call - local private-channel logging stays exactly as it was before any of this, just no longer relayed across bots. - Commodities/00_BasePassiveModule.php: drop the leftover explanatory comment from the #60 revert. - Tests/Stubs/FakeMarketBot.php, Tests/Stubs/FakeRelayBot.php, Tests/Modules/Ao/MarketTest.php, Tests/Modules/RelayTest.php, Tests/README.md: back to their pre-#56 state. Confirmed via `git diff` against the commit before #56 that every touched file is now byte-identical to its pre-feature state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_destination()'s relay hook (added in feat(relay): relay a bot's own command output to the hub bot #56, extended to TELL in feat(relay): relay tell-invoked command output and Market's direct announcements #58) back to its pristine pre-feat(relay): relay a bot's own command output to the hub bot #56 form. Relaying every command reply's full text across the mesh is noisier than wanted, especially since most commands are run via/telldirectly to the hub bot (Tickr).Market.php'sannounce()/announce_background()relay hooks (also from the feat(relay): relay tell-invoked command output and Market's direct announcements #58 follow-up) - those are the lighter-weight "X used market Y" activity-log lines, which is the "command was run" signal actually wanted, and already relays correctly across the mesh (confirmed live).Tests/Commodities/BasePassiveModuleTest.phpand itsFakeOutputDestinationBot.phpstub;Tests/README.mdregenerated (by hand) to match.Modules/Relay.php'srelay_command_output()function itself is untouched - it's still used by Market's two direct call sites.Test plan
Tests/README.mdregenerated (by hand, no local PHP in this environment) to match the removed test file.!market statusoutput) are no longer relayed mesh-wide, while Market's "X used market Y" activity lines still are.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com