fix(core-database): check for missed blocks before applying round#3507
Merged
faustbrian merged 1 commit intoArkEcosystem:2.6from Feb 17, 2020
alessiodf:fix-missed-block-detection
Merged
fix(core-database): check for missed blocks before applying round#3507faustbrian merged 1 commit intoArkEcosystem:2.6from alessiodf:fix-missed-block-detection
faustbrian merged 1 commit intoArkEcosystem:2.6from
alessiodf:fix-missed-block-detection
Conversation
alessiodf
requested review from
air1one,
faustbrian and
kristjank
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
faustbrian
approved these changes
Feb 17, 2020
|
A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3491 by detecting missed blocks before applying the round, since applying the round will repopulate
forgingDelegateswith the order of the new round, but we need to check against the current (old) round to detect the correct delegate if the last delegate in a round misses its block. Otherwise it incorrectly fires for a different delegate in the new round.Checklist