refactor(core-magistrate): make bridgechain genesis hash only unique per wallet#3523
Merged
faustbrian merged 12 commits into2.6from Feb 25, 2020
Merged
Conversation
+ use business index instead of removed bridgechain
|
This pull request introduces 1 alert when merging 56a6508 into 021ad47 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e6514fa into 239f12e - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## 2.6 #3523 +/- ##
==========================================
+ Coverage 66.10% 66.15% +0.04%
==========================================
Files 440 440
Lines 12570 12473 -97
Branches 1733 1714 -19
==========================================
- Hits 8309 8251 -58
+ Misses 4227 4188 -39
Partials 34 34
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist