Skip to content

Make sure the shader execution heap is cache aligned#1159

Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz:lg-heapalign
Apr 24, 2020
Merged

Make sure the shader execution heap is cache aligned#1159
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz:lg-heapalign

Conversation

@lgritz
Copy link
Copy Markdown
Collaborator

@lgritz lgritz commented Apr 23, 2020

No description provided.

@lgritz
Copy link
Copy Markdown
Collaborator Author

lgritz commented Apr 23, 2020

@AlexMWells

@AlexMWells
Copy link
Copy Markdown
Contributor

 if (shadingsys().debug())
        infof("  ShadingContext %p growing heap to %d",
              static_cast<void*>(this), heap_size_needed);

Do you care/mind if you no longer receive this debug info about heap growing? Could add it back to the new helper function. I have no need, just noticed it won't be there anymore.

@lgritz
Copy link
Copy Markdown
Collaborator Author

lgritz commented Apr 23, 2020

No, I thought about that when I deleted it. I don't think it's served any real purpose, so I was ok letting it go.

@AlexMWells
Copy link
Copy Markdown
Contributor

LGTM

@fpsunflower
Copy link
Copy Markdown
Contributor

LGTM2! I like this way better!

@lgritz lgritz merged commit 95bf159 into AcademySoftwareFoundation:master Apr 24, 2020
@lgritz lgritz deleted the lg-heapalign branch April 27, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants