Improve type checking errors with structs#761
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Jun 1, 2017
Merged
Improve type checking errors with structs#761lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
Conversation
Change the implementation of TypeSpec::string(), which returns the text
representation of a TypeSpec, so that it prints the name of the struct
rather than just its numerical designation.
An example of the old behavior, as applied to a type checking error
message:
test.osl:10: error: No matching function call to 'max (struct 1, struct 1)'
Candidates are:
int max (int, int)
float max (float, float)
...
And the new behavior:
test.osl:10: error: No matching function call to 'max (struct vector4, struct vector4)'
Contributor
|
LGTM! |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 24, 2017
) Change the implementation of TypeSpec::string(), which returns the text representation of a TypeSpec, so that it prints the name of the struct rather than just its numerical designation. An example of the old behavior, as applied to a type checking error message: test.osl:10: error: No matching function call to 'max (struct 1, struct 1)' Candidates are: int max (int, int) float max (float, float) ... And the new behavior: test.osl:10: error: No matching function call to 'max (struct vector4, struct vector4)'
lgritz
added a commit
that referenced
this pull request
Oct 25, 2017
Change the implementation of TypeSpec::string(), which returns the text
representation of a TypeSpec, so that it prints the name of the struct
rather than just its numerical designation.
An example of the old behavior, as applied to a type checking error
message:
test.osl:10: error: No matching function call to 'max (struct 1, struct 1)'
Candidates are:
int max (int, int)
float max (float, float)
...
And the new behavior:
test.osl:10: error: No matching function call to 'max (struct vector4, struct vector4)'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the implementation of TypeSpec::string(), which returns the text
representation of a TypeSpec, so that it prints the name of the struct
rather than just its numerical designation.
An example of the old behavior, as applied to a type checking error
message:
And the new behavior: