OSLQuery improvements#821
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Nov 28, 2017
Merged
Conversation
fpsunflower
reviewed
Nov 27, 2017
| isstruct(false), isclosure(false), data(NULL) | ||
| { } | ||
|
|
||
| Parameter () {} |
Contributor
There was a problem hiding this comment.
Is there any need to declare these? Don't you just want the "default" behavior?
Collaborator
Author
There was a problem hiding this comment.
For the copy and move constructors, it's important that the data pointer refers to ITS OWN default field, not a straight pointer copy from the source. So default ctrs won't work.
Contributor
There was a problem hiding this comment.
Ah I missed that detail.
LGTM!
* OSLQuery::Parameter -- add copy/move constructors * Make the ShadingSystem side of OSLQuery correctly report default vals.
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Nov 28, 2017
* OSLQuery::Parameter -- add copy/move constructors * Make the ShadingSystem side of OSLQuery correctly report default vals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSLQuery::Parameter -- add copy/move constructors
Make the ShadingSystem side of OSLQuery correctly report default vals.