New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): mount database and log paths as volumes #2064

Merged
merged 13 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@adrian69
Copy link
Collaborator

adrian69 commented Feb 5, 2019

Proposed changes

Mount database and log paths as docker volumes - make them accessible locally at any time as well preserve pool and snapshots data on container delete.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

adrian69 and others added some commits Jan 28, 2019

@adrian69 adrian69 requested a review from faustbrian Feb 5, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 5, 2019

@faustbrian @supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #2064 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2064   +/-   ##
========================================
  Coverage    73.76%   73.76%           
========================================
  Files          367      367           
  Lines         8261     8261           
  Branches      1177     1186    +9     
========================================
  Hits          6094     6094           
+ Misses        2134     2132    -2     
- Partials        33       35    +2
Impacted Files Coverage Δ
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f65b5...cad9284. Read the comment docs.

@faustbrian faustbrian changed the title Update - mount database and log paths as volumes build(docker): mount database and log paths as volumes Feb 5, 2019

@faustbrian faustbrian merged commit 235300f into ArkEcosystem:develop Feb 5, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Feb 6, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  test(core-blockchain): increase coverage (#2066)
  chore: ignore a few things for coverage
  chore(docker): mount database and log paths as volumes (#2064)
  chore: docker production set (#2063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment