build(docker): mount database and log paths as volumes#2064
Merged
faustbrian merged 13 commits intoArkEcosystem:developfrom Feb 5, 2019
adrian69:develop
Merged
build(docker): mount database and log paths as volumes#2064faustbrian merged 13 commits intoArkEcosystem:developfrom adrian69:develop
faustbrian merged 13 commits intoArkEcosystem:developfrom
adrian69:develop
Conversation
|
@faustbrian @supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2064 +/- ##
========================================
Coverage 73.76% 73.76%
========================================
Files 367 367
Lines 8261 8261
Branches 1177 1186 +9
========================================
Hits 6094 6094
+ Misses 2134 2132 -2
- Partials 33 35 +2
Continue to review full report at Codecov.
|
faustbrian
changed the title
faustbrian
approved these changes
Feb 5, 2019
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Mount database and log paths as docker volumes - make them accessible locally at any time as well preserve pool and snapshots data on container delete.
Types of changes
Checklist