test(core-transactions): increase coverage to 100%

[sebastijankuzner]

Summary

What changes are being made?

Rewrite tests for core-transactions. Refactor some things that causes a problem with tests.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

Some things that need a better look and maybe refactoring were marked with todo comment (handler.test.ts).

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@3b94516). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop    #3520   +/-   ##
==========================================
  Coverage           ?   56.89%           
==========================================
  Files              ?      548           
  Lines              ?    13661           
  Branches           ?     1867           
==========================================
  Hits               ?     7773           
  Misses             ?     5859           
  Partials           ?       29

Impacted Files	Coverage Δ
...core-webhooks/src/server/plugins/trailing-slash.ts	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b94516...aa92515. Read the comment docs.

[faustbrian]

You can check https://codecov.io/gh/ArkEcosystem/core/tree/test%2Ftest-core-transactions/packages/core-transactions/src to see what is still missing coverage to get to 100%.

[sebastijankuzner]

Coverage is increased to almost 100%, some code cannot be tested, because it is unreachable. There are some refactoring in the core-transaction package and included merge from branch: fix(core-transactions): undefined pool variable #3535.

[faustbrian]

Coverage is increased to almost 100%, some code cannot be tested, because it is unreachable.

There is no such thing as code that can't be tested but if it is difficult to test certain code that means you should refactor it to get coverage for it or remove it if you are certain that it is unreachable by the application.

[sebastijankuzner]

The coverage should now be 100%.