fix(core-transactions): undefined pool variable#3535
Merged
faustbrian merged 5 commits into3.0from Feb 28, 2020
Merged
Conversation
d68eebf to
e4bd0a0
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #3535 +/- ##
==========================================
- Coverage 47.52% 9.82% -37.70%
==========================================
Files 548 548
Lines 13861 13861
Branches 1902 1902
==========================================
- Hits 6587 1362 -5225
- Misses 7245 12476 +5231
+ Partials 29 23 -6
Continue to review full report at Codecov.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Undefined pool variable was suppressed by
@ts-ignoreand I missed it. Wallet repository can be referenced bythis.walletRepository.Checklist