This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: get children of TransitionGroup when available & word-break of vendorfield #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo,
j-a-m-l and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
j-a-m-l
added
the
Bounty: Tier 3
ghost
mentioned this pull request
j-a-m-l
suggested changes
May 17, 2019
|
Will take a look in the morning! |
|
@j-a-m-l can you check with the team if this is by design? This block has been there for quite a while. |
|
The border should be visible when expanded too |
|
If I remember correctly the border did some weird stuff when expanding. Try removing it @dated and see what happens. If it's okay then can remove it completely |
|
i'll re-check as soon as i get a chance. |
|
it looks okay to me @alexbarnsley |
|
Okay great @dated, happy for you to remove it. Maybe the issue it was hiding will represent itself in a few months 😆 |
|
been there, done that f41baa9 😉 |
|
You didn't even wait for confirmation! I should have said the opposite |
j-a-m-l
approved these changes
May 21, 2019
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Member Approved
|
Your pull request has been merged and marked as tier 3. It will earn you $25 USD. |
ghost
mentioned this pull request
alexbarnsley
added a commit
that referenced
this pull request
Jun 26, 2019
* fix: improve validation for epoch format (#1164) * chore: upgrade Vue and other dependencies and use Node 11 on CI (#1160) * feat: allow using a pool of background workers and use create a unified HTTP client (#1120) * fix: `InputSelect` dropdowns (#1174) * fix: `InputSelect` dropdowns * refactor: use the new Vue 2.6 syntax for named slots * fix: do not allow more than 1 `InputSelect` open at the same time * fix: other network fees when higher than ARK default static fees (#1172) * fix: main sidebar menus (settings and peers/networks) (#1175) * fix: the wallet selection dropdown and the wallet sidebar filters (#1184) * fix: do not fail when navigating to other page while loading transactions (#1185) * fix: use of getStruct in ledger transactions (#1190) * chore: add ItsANameToo as code owner * fix: add network modal validation (#1173) * fix: network validation being overwritten * feat: pull active delegates from api * fix: make sure active delegates value exists * refactor: improve server regex * test: network modal for adding network * chore: replace todo with comment * fix: use one loop with prefilled values as backup * refactor: allow string or number for input text * refactor: allow fetching fees for specific network * fix: fetch network fees when adding/editing * fix: fetch fees & wait before add/update * chore: remove mario from contributors (#1196) * chore: add Altilly Exchange Wallet (#1199) * fix: align the add profile placeholder (#1202) * fix: days on the X axis of the market chart (#1203) * fix: fetch fees only if the network is available (#1206) * fix: stop hover from displacing address container (#1242) * fix: vue-i18n-extract commands (#1247) * refactor: require user action when generating 2nd passphrase (#1229) * feat: store sidebar sorting and filters (#1148) * feat: add option to hide the wallet button text (#1146) * fix: get children of TransitionGroup when available & word-break of vendorfield (#1234) * feat: show remaining bytes in vendorfield helper text (#1259) * chore: use organization-wide GitHub Configuration (#1267) * misc: Italian language update (#1268) * fix: tidy permission method names & check exists (#1260) * feat: add option to export wallets (#1244) * feat: use the theme colours for the wallet filters instead of white (#1270) * deps: upgrade `axios` (CVE-2019-10742) (#1271) * fix: saving of invalid profile name on leave (#1101) * bugfix: saving of invalid profile editions * refactor: dont disable save button when profile name valid even when the 'isNameEditable' don't disable save button. Instead disable it only when the name has an error. * Update en-US.js * Update ProfileEdition.vue * refactor: show failed update message on close * refactor: add update failure reason * fix: disable both save buttons if name invalid * fix: display the wallet sidebar filters on the right position (#1201) * fix: highlight filters button when expanded if active * fix: display the wallet sidebar filters on the right position * refactor: add the status icon and plus/minus sign in the transaction show modal (#1272) * fix: use webview instead of iframe for changelly (#1277) * revert: worker changes from commit e42290 * refactor: use nock to mock tests (#1291) * fix: add options mock requests * fix: tests not mocking api * fix: duplicated key warning on `WalletNew` * Update src/renderer/pages/Wallet/WalletNew.vue Co-Authored-By: Edgar Goetzendorff <hello@dated.fun> * fix: ledger options on build (#1300) * fix: ledger options on build * fix: use component directly * fix: change order of arguments in uniqBy call (#1297) * fix: don't close custom peer modal when clicking inside (#1204) * refactor: rename `NetworkCustomPeer` to `NetworkCustomPeerModal` * fix: do not close the custom peer modal when clicking inside it * refactor: wallet address & balance clickable on WalletAll page (#1301) * fix: ledger wallet sidebar filter (#1292) * fix: ledger whitescreen (#1296) * fix: ledger whitescreen errors * refactor: all ledger errors are failures * refactor: improve ledger connection check * refactor: improve ledger & use hid-singleton * test: fix failing * chore: remove e2e tests * fix: open transaction modal on dashboard (#1281) * fix: remove deeplink validation prefix * fix: open transaction modal on dashboard * fix: don't switch twice when selecting wallet on WalletSidebar (#1302) * chore: bump version to 2.5.0 (#1303)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes and closes #1222 (both issues).
Types of changes
Checklist
Further comments
collections_filterChildrenwould fail to collect the navigation items if they were wrapped in aTransitionGroup. That method now checks for such a container and adjusts therefaccordingly.