Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: add the status icon and plus/minus sign in the transaction viewer #1272
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
If adding a new feature, the PR's description includes:
requested review from
May 30, 2019
@@ Coverage Diff @@ ## develop #1272 +/- ## ========================================== + Coverage 40.13% 40.2% +0.06% ========================================== Files 231 232 +1 Lines 6368 6372 +4 Branches 1248 1248 ========================================== + Hits 2556 2562 +6 + Misses 3591 3589 -2 Partials 221 221
j-a-m-l left a comment
On the transaction show modal, unconfirmed transactions display the clock icon instead of the sent/received arrow. Pobably it would be better to show the arrows instead, specially since the clock icon is already used on the confirmations field.