feat: add option to export wallets

[dated]

Proposed changes

Adds the option to export ones wallets, closing #1142.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improve a current implementation without adding a new feature or fixing a bug)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Build (changes that affect the build system)
• Docs (documentation only changes)
• Test (adding missing tests or fixing existing tests)
• Other... Please describe:

Checklist

• I have read the CONTRIBUTING documentation
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

The exported wallets have the following format:

{
  "network": {
    "name": "ARK Devnet",
    "nethash": "2a44f340d76ffc3df204c5f38cd355b7496c9065a1ade2ef92071436bd72e867",
    "token": "DARK",
    "symbol": "DѦ"
  },
  "wallets": [
    {
      "username": "alessio",
      "address": "DSyG9hK9CE8eyfddUoEvsga4kNVQLdw2ve",
      "publicKey": "033a5474f68f92f254691e93c06a2f22efaf7d66b543a53efcece021819653a200",
      "vote": {
        "username": "dated_test_del",
        "publicKey": "02d2f48a7ebb5b6d484de15b4cab8ab13c1d39b7141301efe048714aa9d82eb1cd"
      },
      "balance": {
        "DARK": "2192334.43948647"
      }
    }
  ]
}

[ghost]

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[ghost]

The ci/circleci: test-node-11 job is failing as of af1dbcf11a30fd740caee3a3b2b68d47d2bc4472. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[dated]

any feedback is appreciated @alexbarnsley @j-a-m-l @ItsANameToo

[j-a-m-l]

@dated you've done a great job.

On the UI there are some things that I'd change:

• We would need later an import feature, but we're already using that name, so we would have to rename it to "recover" or something similar, or use a different concept for exporting them. Maybe "download" or "save", or something in that line.
• It's necessary to explain that the file doesn't contain the passphrase, so it can't be used as a backup.

I'd add another option to include the balance and other data of the wallet.

[dated]

I'll add a notice to the modal regarding the passphrase, for the import a 'Batch Import' button could be added to the import page?

[j-a-m-l]

I'm not sure about that option; we could rename the buttons to "Import Wallets", but that page would need a modal to import the wallets and it would break the step style and behaviour of the process, so it wouldn't fit there smoothly.

I'd rather add other button. Maybe "Batch Import", near the "Import Wallet" button is clear enough.

[zillionn]

I guess this will be a nice feature when you're switching computers or reinstalling the OS, right? If yes, how about to export the whole Profile with its settings and everything? Then when you install the desktop wallet on the new comp, you'll have an option to import the profile.

[j-a-m-l]

Yes, exporting the whole profile could be a feature. In that case it would include data to import the network in case it doesn't exist yet.

[dated]

The ledger option is now disabled if no ledger is connected and I've added some more fields for now:

  "wallets": [
    {
      "ANoNeeFDFo61XcQBYad6rEbPvfATwgjTNT": {
        "name": "test",
        "publicKey": "02ead78d2ecd00a966f45c1ea3fb8d2e032dcb704a451a1af0426789261d37459a",
        "balance": {
          "ARK": "1780.56728118",
          "USD": "1105.27"
        }
      }
    }
  ]

I'll try to add the remaining fields and some tests tomorrow.

[dated]

I would refrain from the transaction counts for now as the API does return wrong values, and I don't see much use for that information anyway.

The other fields have been added. I removed the address as key and added it as a property. Are you ok with the current format @j-a-m-l?

[ghost]

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

[dated]

Thanks for the review @luciorubeens, I'll get the changes done asap.

[dated]

All fixed, thanks again @luciorubeens.

[ghost]

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[ghost]

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[ghost]

Your pull request has been merged and marked as tier 0. It needs a specialized, in-depth review before we can decide on its value.