Skip to content

Gallery Widget: translate "Choose Images" - #111

Merged
georgestephanis merged 2 commits into
Automattic:masterfrom
jeherve:i18n-gallery-widget
Jan 23, 2014
Merged

Gallery Widget: translate "Choose Images"#111
georgestephanis merged 2 commits into
Automattic:masterfrom
jeherve:i18n-gallery-widget

Conversation

@jeherve

@jeherve jeherve commented Jan 22, 2014

Copy link
Copy Markdown
Member

No description provided.

@cathyjf

cathyjf commented Jan 22, 2014

Copy link
Copy Markdown
Contributor

@jeherve, perhaps you should also translate the same string earlier on that line when it appears in the title attribute? Can you add that or is there some reason not to?

@ghost ghost assigned cathyjf Jan 22, 2014
@jeherve

jeherve commented Jan 22, 2014

Copy link
Copy Markdown
Member Author

I actually posted #110 right before this Pull Request, where I proposed that we delete the title attribute altogether. That's actually how I spotted the missing translation.

Would you like me to update this PR to translate title as well, until we make a decision about the other PR?

georgestephanis added a commit that referenced this pull request Jan 23, 2014
Gallery Widget: translate "Choose Images"
@georgestephanis
georgestephanis merged commit 72fbafd into Automattic:master Jan 23, 2014
@jeherve
jeherve deleted the i18n-gallery-widget branch January 23, 2014 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants