Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 20, 2019

Fixes #11504

Changes proposed in this Pull Request:

Restores native functionality wrt VP and Akismet plugin info cards.

Testing instructions:

  • Go to Plugins-Add New
  • Search for "VaultPress"
  • Before patch: See the Jetpack PSH, but no card for VaultPress.
  • After patch: See the Jetpack PSH AND the VaultPress card.

Proposed changelog entry for your changes:

  • Plugin Search Hints: Display Akismet and VaultPress as normal when returned by Core search.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] High Plugin Search aka Feature Hints labels Mar 20, 2019
@kraftbj kraftbj added this to the 7.2 milestone Mar 20, 2019
@kraftbj kraftbj requested a review from a team March 20, 2019 16:09
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 3062a02

Copy link
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Kraft!

Hopefully this isn't too confusing :)
image

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 21, 2019
@kraftbj kraftbj merged commit 361a99f into master Mar 21, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 21, 2019
@kraftbj kraftbj deleted the fix/11504 branch March 21, 2019 18:49
kraftbj added a commit that referenced this pull request Mar 26, 2019
kraftbj added a commit that referenced this pull request Mar 27, 2019
* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Add CL for #11224

* Add CL for #11426

* Add CL for #11442

* Add testing instructions for #11224

* Add CL for #11451

* Reclassify CL item

* Add testing instructions for #11451

* Add CL for #11486

* Add CL for #11418

* Add CL for #11524

* Add CL and testing instructions for #11449

* Add CL for #11460

* Add CL for #11520 and #11582

* Add CL for #11531

* Add CL #11644

* Add testing instructions for #11644

* Add testing instructions for #11644

* Add CL for #11618

* Uniform changelog lines

* CL #11679

* CL #11661

* CL #11654

* CL #11645

* CL #11643

* CL #11636

* CL #11635 and for other PHPCS commits

* CL #11627

* CL #11626

* CL #11598

* CL #11596

* Remove nested items for shortcopy. I don't believe the detailed list is helpful

* CL #11570

* CL #11569

* CL #11560

* CL #11558

* CL #11555

* CL #6704

* CL #11298

* CL #11324

* CL #11443

* CL #11484

* CL #11516

* CL #11529

* Expand Ads block enhancement CL item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Plugin Search aka Feature Hints [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants