Skip to content

Shortcopy: update illustrations on plan headers #11645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliorivero merged 3 commits into from
Mar 22, 2019
Merged

Shortcopy: update illustrations on plan headers #11645

eliorivero merged 3 commits into from
Mar 22, 2019

Conversation

@eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Mar 21, 2019 •
edited
Loading

Fixes #11541

Changes proposed in this Pull Request:

  • add new illustrations on My Plan header
  • update styles for a proper layout

Desktop

Captura de pantalla 2019-03-21 a la(s) 18 29 16

Tablet

Captura de pantalla 2019-03-21 a la(s) 18 29 32

Phone

Captura de pantalla 2019-03-21 a la(s) 19 03 57

Small Phone <480

Captura de pantalla 2019-03-21 a la(s) 19 04 15

Testing instructions:

  • Go to the Jetpack dashboard and click My Plan
  • Ensure that everything looks correct

Proposed changelog entry for your changes:

  • Not needed. Part of Shortcopy project.

@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu labels Mar 21, 2019
@eliorivero eliorivero added this to the 7.2 milestone Mar 21, 2019
@eliorivero eliorivero self-assigned this Mar 21, 2019
@eliorivero eliorivero requested review from a team, jeffgolenski and keoshi March 21, 2019 18:35
@keoshi
Copy link
Contributor

keoshi commented Mar 21, 2019

You're a champ, @eliorivero !

Will give it a run tomorrow morning, but from the screenshots it looks like their size is adding a lot of empty space at the bottom. Can we reduce their total size without losing the vertical alignment of the titles/paragraphs?

Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Mar 21, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against cc17dfa

@eliorivero eliorivero force-pushed the update/shortcopy-plan-icons branch from ba08ec5 to be45e50 Compare March 21, 2019 18:41
@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 21, 2019
kraftbj
kraftbj previously approved these changes Mar 21, 2019
View reviewed changes
@kraftbj
Copy link
Contributor

kraftbj commented Mar 21, 2019

Approved from the code POV. Merge when design review is finished if no changes are required.

@eliorivero eliorivero force-pushed the update/shortcopy-plan-icons branch from bbd8aea to cc17dfa Compare March 21, 2019 22:07
@eliorivero
Copy link
Contributor Author

eliorivero commented Mar 21, 2019

@keoshi done, centered the title and paragraph as well as the icon. Screenshots are up to date. LMK if it's ok now.

keoshi
keoshi approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stuff, Elio! Thanks so much again. Let’s ship it! 🛳

@eliorivero eliorivero merged commit 48bd35a into master Mar 22, 2019
@eliorivero eliorivero deleted the update/shortcopy-plan-icons branch March 22, 2019 02:53
kraftbj added a commit that referenced this pull request Mar 26, 2019
@kraftbj
CL #11645
111ebea
kraftbj added a commit that referenced this pull request Mar 27, 2019
@kraftbj
Add initial 7.2 changelog to master (#11690)
2227bfd 
* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Add CL for #11224

* Add CL for #11426

* Add CL for #11442

* Add testing instructions for #11224

* Add CL for #11451

* Reclassify CL item

* Add testing instructions for #11451

* Add CL for #11486

* Add CL for #11418

* Add CL for #11524

* Add CL and testing instructions for #11449

* Add CL for #11460

* Add CL for #11520 and #11582

* Add CL for #11531

* Add CL #11644

* Add testing instructions for #11644

* Add testing instructions for #11644

* Add CL for #11618

* Uniform changelog lines

* CL #11679

* CL #11661

* CL #11654

* CL #11645

* CL #11643

* CL #11636

* CL #11635 and for other PHPCS commits

* CL #11627

* CL #11626

* CL #11598

* CL #11596

* Remove nested items for shortcopy. I don't believe the detailed list is helpful

* CL #11570

* CL #11569

* CL #11560

* CL #11558

* CL #11555

* CL #6704

* CL #11298

* CL #11324

* CL #11443

* CL #11484

* CL #11516

* CL #11529

* Expand Ads block enhancement CL item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdawaffe mdawaffe mdawaffe approved these changes

@keoshi keoshi keoshi approved these changes

@kraftbj kraftbj kraftbj left review comments

@jeffgolenski jeffgolenski Awaiting requested review from jeffgolenski

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

7 participants

@eliorivero @keoshi @jetpackbot @kraftbj @mdawaffe @matticbot