Skip to content

Protect: Change math check to init hook - #3686

Merged
samhotchkiss merged 1 commit into
masterfrom
fix/protect-math-frontend
Jun 10, 2016
Merged

Protect: Change math check to init hook#3686
samhotchkiss merged 1 commit into
masterfrom
fix/protect-math-frontend

Conversation

@samhotchkiss

Copy link
Copy Markdown
Contributor

Fixes an issue where the Protect math form doesn't show up on front end login forms

Changes proposed in this Pull Request:

  • Changes math check from login_head to init hook

@samhotchkiss samhotchkiss added the [Status] Needs Review This PR is ready for review. label Apr 18, 2016
@samhotchkiss samhotchkiss added this to the 4.0.1 milestone Apr 18, 2016
@samhotchkiss samhotchkiss added the [Feature] Protect Also known as Brute Force Attack Protection label Apr 18, 2016
@jeherve jeherve added the Bug When a feature is broken and / or not performing as intended label Apr 19, 2016
@RavanH

RavanH commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

Fantastic! This fixes an issue with the bbPress login widget :)

@jeherve jeherve modified the milestones: 4.0.1, 4.0.2, 4.0.3 Apr 21, 2016
@RavanH

RavanH commented Apr 23, 2016

Copy link
Copy Markdown
Contributor

Funny thing though: it seems to work sometimes but most of the times it's not. Sometimes the math puzzle is shown below the bbPress login widget (when it's there, login is easy) but when it's not, login will always direct to a math puzzle which in turn (solved or not) will always direct to the main login.php which demands again a login + math puzzle... Which is very annoying.

Any way to make the math puzzle show below the bbPress widget login form constantly?

@RavanH

RavanH commented Apr 26, 2016

Copy link
Copy Markdown
Contributor

Showing the issue may be much clearer: https://status301.net/schermfilm-van-26-04-2016-213100/ (note the difference in the login widget form between the first and second time)

@jeherve jeherve modified the milestones: 4.0.3, 4.0.4 May 11, 2016
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jun 9, 2016
@samhotchkiss

Copy link
Copy Markdown
Contributor Author

Hi Ravan-- This, combined with another change we made, should significantly improve things-- once you're running all of 4.0.4, if you're still running into this on a regular basis, please submit a support request and I can help you out through that channel.\

Thanks!

@samhotchkiss
samhotchkiss merged commit 2d338ed into master Jun 10, 2016
@samhotchkiss
samhotchkiss deleted the fix/protect-math-frontend branch June 10, 2016 03:23
@jeherve jeherve removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 10, 2016
jeherve added a commit that referenced this pull request Jun 13, 2016
jeherve added a commit that referenced this pull request Jun 14, 2016
dereksmart pushed a commit that referenced this pull request Jun 20, 2018
* Protect: Change math check to init hook again

See merge #3686 by @samhotchkiss and issue #5144 by @jeherve ... unless there is a particular reason to limit this to login_init?

Additional change to line 61 for full bbPress Login Widget compatibility while keeping $pagenow fallback functional.

* Update protect.php

Fix action order (check_use_math after check_login_ability) while keeping Login Widget compatibility.

* Update protect.php

* Update protect.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Protect Also known as Brute Force Attack Protection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants