Skip to content

Boost: Delete static minification option on atomic - #42249

Merged
dilirity merged 3 commits into
trunkfrom
fix/boost/atomic-clear-minification-option
Mar 6, 2025
Merged

Boost: Delete static minification option on atomic#42249
dilirity merged 3 commits into
trunkfrom
fix/boost/atomic-clear-minification-option

Conversation

@dilirity

@dilirity dilirity commented Mar 6, 2025

Copy link
Copy Markdown
Member

Proposed changes:

  • On plugin update, delete static notification option, to prevent the "Serve static concatenate notice" from showing.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1741256084040749/1741178339.776799-slack-C016BBAFHHS

Does this pull request change what data or activity we track or use?

no

Testing instructions:

You need an atomic site running 3.9.0 with Concatenate JS or CSS running.

  • Update to this version and make sure you don't see this notice:

image

dilirity added 2 commits March 6, 2025 12:24
This is necessary, to disable the static minification notice on atomic,
in case an atomic website was running 3.9.0 with Concat JS/CSS enabled.
@dilirity dilirity added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. [Platform] Atomic [Boost Feature] Minify labels Mar 6, 2025
@dilirity dilirity added this to the boost/3.10.1 milestone Mar 6, 2025
@dilirity
dilirity requested a review from a team March 6, 2025 10:26
@github-actions

github-actions Bot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

jp-launch-control Bot commented Mar 6, 2025

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/class-jetpack-boost.php 0/91 (0.00%) 0.00% 3 ❤️‍🩹
projects/plugins/boost/app/lib/minify/functions-service.php 13/173 (7.51%) -0.04% 1 ❤️‍🩹

Full summary · PHP report · JS report

@dilirity dilirity left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a self-review and tested on Atomic. Notice is no longer showing up as the option is no longer being set.

@dilirity
dilirity merged commit e8086cb into trunk Mar 6, 2025
@dilirity
dilirity deleted the fix/boost/atomic-clear-minification-option branch March 6, 2025 11:23
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Boost Feature] Minify Bug When a feature is broken and / or not performing as intended [Platform] Atomic [Plugin] Boost A feature to speed up the site and improve performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants