Newsletter: Move admin notices and JITMs below page header#47714
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Move GlobalNotices to render before the form content instead of after it, and add a #jp-admin-notices container for JITM injection. This follows the same pattern established in PR #47558 for My Jetpack, Social, and Search. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e126584 to
71c2553
Compare
* Newsletter: Move admin notices and JITMs below page header Move GlobalNotices to render before the form content instead of after it, and add a #jp-admin-notices container for JITM injection. This follows the same pattern established in PR #47558 for My Jetpack, Social, and Search. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Newsletter: Use CSS logical properties for JITM card margins Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add changelog for newsletter admin notices fix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>



Fixes JETPACK-1484
Proposed changes
GlobalNoticesto render immediately after the<AdminPage>open tag, before the form content (was previously at the bottom after all sections)#jp-admin-noticescontainer for JITM injection, positioned below the header in its own zero-spacingContainer/Colpairmargin-inline-end,margin-block) for RTL-safe JITM card stylingThis follows the same pattern established in #47558 for My Jetpack, Social, and Search — the Newsletter page was missed in that PR.
Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack_jitm_received_envelopesfilter to verify JITM placement below the header