My Jetpack: use ui-icon instead of CheckmarkIcon

[simison]

Part of #48160

Proposed changes

Just one-to-one replacement of checkmark:

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

First, go to My Jetpack.

The product-detail-card component is the interstitial/detail page shown when you click on a specific product from the My Jetpack overview. It's the full-screen product landing page, not the card on the main grid.

To see it in My Jetpack, navigate to My Jetpack → click any product card (e.g. Backup, Scan, Boost). That takes you to a URL like:

/wp-admin/admin.php?page=my-jetpack#/add-backup
The ProductDetailCard renders the large product description, pricing, features list, and CTA buttons on that interstitial screen. The CheckmarkIcon you changed specifically appears when isBundleUpsell && hasPaidPlanForProduct is true — so you'd see it on a bundle product (like Security or Complete) when the user already has a paid plan that covers it, showing the "Active on your site" checkmark.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the upadte/rna-checkmark-icon-my-jp branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack upadte/rna-checkmark-icon-my-jp

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[nerrad]

Quick review — couple of observations below. Nothing blocking.

*left by Biff (executive assistant agent) on behalf of Darren

[nerrad]

Just confirming this is known and intentional — the icon swap also drops the previous green fill, since CheckmarkIcon defaulted to className="checkmark-icon" (→ fill: var(--jp-green-primary)) in projects/js-packages/components/components/icons/style.module.scss. The surrounding .product-has-required-plan svg rule in this component only sets margin-right, so the new <Icon icon={ check } /> renders without the green fill. There's also a small glyph difference (filled circle-check vs. plain checkmark stroke).

Verified live on a Jurassic Ninja site with this PR's build deployed — computed fill is rgb(6, 158, 8) for the old icon vs rgb(0, 0, 0) for the new one:

*left by Biff (executive assistant agent) on behalf of Darren

[nerrad]

@simison - equivalent use (related to the screenshot in your PR description is here and styled here.

If I force a tweak to simulate "active on site" for Jetpack Security (which uses this component):

But we still have other green checks on the page?

[nerrad]

[suggestion] Two small things on this changelog file:

1. Filename collides with Replace RNA Gridicon with wp-ui Icon #48164 — that PR also adds projects/packages/my-jetpack/changelog/rna-gridicon. Whichever merges second will hit a conflict on this path. Renaming this file to something like rna-checkmark-icon avoids it.
2. Message overstates the scope — the body says "Replace Gridicon and CheckmarkIcon…" but this PR only touches CheckmarkIcon. Gridicon replacement lives in Replace RNA Gridicon with wp-ui Icon #48164. Trimming to just CheckmarkIcon keeps the changelog accurate.

*left by Biff (executive assistant agent) on behalf of Darren