Skip to content

My Jetpack: replace Badge from automattic/ui with wordpress/ui#48167

Open
simison wants to merge 2 commits intotrunkfrom
update/replace-automattic-ui-badge-with-wp-ui
Open

My Jetpack: replace Badge from automattic/ui with wordpress/ui#48167
simison wants to merge 2 commits intotrunkfrom
update/replace-automattic-ui-badge-with-wp-ui

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 18, 2026

Part of #48160

Proposed changes

  • Switch from automattic/ui package to wordpress/ui for Badge (docks)

Before
Screenshot 2026-04-18 at 14 42 59

After
Screenshot 2026-04-18 at 12 22 48

When status cannot be retrieved, we instead show a "medium" badge for the error state. You could test that by short-cirquiting the code.

Here are all the intents of component

image

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Test My Jetpack UIs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/replace-automattic-ui-badge-with-wp-ui branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/replace-automattic-ui-badge-with-wp-ui
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/replace-automattic-ui-badge-with-wp-ui

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 18, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Apr 18, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison marked this pull request as ready for review April 18, 2026 19:50
@simison simison force-pushed the update/replace-automattic-ui-badge-with-wp-ui branch from 44a9206 to 22f16da Compare April 18, 2026 19:52
@simison simison requested a review from a team April 18, 2026 19:53
@simison simison added [Status] Needs Review This PR is ready for review. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Apr 18, 2026
Significance: minor
Type: changed

Replace Badge from `@automattic/ui` with Badge from `@wordpress/ui`, and CheckmarkIcon with Icon from `@wordpress/icons`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor/nit: this entry mentions "and CheckmarkIcon with Icon from @wordpress/icons", but this PR doesn't touch CheckmarkIcon — the import at _inc/components/product-detail-card/index.jsx:2 (from @automattic/jetpack-components) is unchanged. That migration is tracked in #48165. Consider dropping the CheckmarkIcon clause here so the changelog matches what actually shipped in this PR.

*left by Biff (executive assistant agent) on behalf of Darren

Copy link
Copy Markdown
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay. Minor nit on the changelog entry surfaced by agent review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] My Jetpack Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants