My Jetpack: replace Badge from automattic/ui with wordpress/ui#48167
My Jetpack: replace Badge from automattic/ui with wordpress/ui#48167
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
44a9206 to
22f16da
Compare
| Significance: minor | ||
| Type: changed | ||
|
|
||
| Replace Badge from `@automattic/ui` with Badge from `@wordpress/ui`, and CheckmarkIcon with Icon from `@wordpress/icons`. |
There was a problem hiding this comment.
Minor/nit: this entry mentions "and CheckmarkIcon with Icon from @wordpress/icons", but this PR doesn't touch CheckmarkIcon — the import at _inc/components/product-detail-card/index.jsx:2 (from @automattic/jetpack-components) is unchanged. That migration is tracked in #48165. Consider dropping the CheckmarkIcon clause here so the changelog matches what actually shipped in this PR.
*left by Biff (executive assistant agent) on behalf of Darren
nerrad
left a comment
There was a problem hiding this comment.
Changes look okay. Minor nit on the changelog entry surfaced by agent review.
Part of #48160
Proposed changes
automattic/uipackage towordpress/uifor Badge (docks)Before

After

When status cannot be retrieved, we instead show a "medium" badge for the error state. You could test that by short-cirquiting the code.
Here are all the intents of component
Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions