Skip to content

Newsletter: label subscription placement options with a section header#49466

Merged
CGastrell merged 1 commit into
trunkfrom
change/newsletter-add-subscriber-copy-cft
Jun 9, 2026
Merged

Newsletter: label subscription placement options with a section header#49466
CGastrell merged 1 commit into
trunkfrom
change/newsletter-add-subscriber-copy-cft

Conversation

@CGastrell

@CGastrell CGastrell commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

From the p8oabR-1P8-p2 feedback on the modernized Newsletter dashboard: the subscription form placement options (overlay / pop-up / Subscribe block) had no heading. This adds a "Homepage and posts" section header above the options grid, matching the existing labeled section below it (the label mirrors the component's own internal "Homepage and posts" naming). Labeling only — no behavior change.

Subscription placement options with the new Homepage and posts header

Related product discussion/links

  • Call for Testing: Modernized Jetpack Dashboards (Newsletter, VideoPress & Social) p8oabR-1P8-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • On a site with the modernized Newsletter dashboard, go to Jetpack → Newsletter → Settings and scroll to the subscription form placement options (overlay / pop-up / Subscribe block).
  • Confirm a "Homepage and posts" section header now appears above the options grid, consistent with the labeled section beneath it.
  • Confirm nothing else in the Settings tab changed — this PR is labeling only.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the change/newsletter-add-subscriber-copy-cft branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack change/newsletter-add-subscriber-copy-cft

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 8, 2026
@jp-launch-control

jp-launch-control Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Add a "Homepage and posts" section header above the subscription placement
options grid so the grouped options are labeled, matching the labeled section
below it. From Call-for-Testing feedback on the modernized Newsletter dashboard.
@CGastrell CGastrell force-pushed the change/newsletter-add-subscriber-copy-cft branch from 9c51bde to 5a6aa03 Compare June 8, 2026 20:00
@CGastrell CGastrell changed the title Newsletter: clarify Add subscribers CSV copy and label placement options Newsletter: label subscription placement options with a section header Jun 8, 2026
@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jun 8, 2026
@CGastrell CGastrell marked this pull request as ready for review June 8, 2026 20:15
@CGastrell CGastrell merged commit d95d561 into trunk Jun 9, 2026
82 of 85 checks passed
@CGastrell CGastrell deleted the change/newsletter-add-subscriber-copy-cft branch June 9, 2026 13:26
@github-actions github-actions Bot removed [Status] In Progress [Status] Needs Review This PR is ready for review. labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Newsletter [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants