Newsletter: label subscription placement options with a section header#49466
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Add a "Homepage and posts" section header above the subscription placement options grid so the grouped options are labeled, matching the labeled section below it. From Call-for-Testing feedback on the modernized Newsletter dashboard.
9c51bde to
5a6aa03
Compare
Fixes #
Proposed changes
From the p8oabR-1P8-p2 feedback on the modernized Newsletter dashboard: the subscription form placement options (overlay / pop-up / Subscribe block) had no heading. This adds a "Homepage and posts" section header above the options grid, matching the existing labeled section below it (the label mirrors the component's own internal "Homepage and posts" naming). Labeling only — no behavior change.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions