Verbum Comments: surface login requirement when in-frame social login is unavailable#50396
Verbum Comments: surface login requirement when in-frame social login is unavailable#50396arcangelini wants to merge 1 commit into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
| </div> | ||
| <a | ||
| className="components-button is-primary" | ||
| href={ getSiteLoginUrl() } |
| </div> | ||
| <a | ||
| className="components-button is-primary" | ||
| href={ getSiteLoginUrl() } |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Proposed changes
On Atomic sites that require login to comment (
comment_registrationenabled), logged-out visitors were shown a comment form with no way to log in — the social login options don't render in the cross-origin iframe, and submitting the guest form just returns "Sorry, you must be logged in to comment." A dead end.This surfaces the login requirement up front instead of after a failed submit:
wp-login.php, opened top-level), so the visitor returns authenticated via Jetpack SSO and can comment.This is a frontend-only change (plus one translatable string) and does not alter behavior for any case other than that specific dead-end state.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions