Premium analytics: remove token fallbacks - #50566
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
10e8493 to
87d619f
Compare
retrofox
left a comment
There was a problem hiding this comment.
LGTM. I've tested the branch and didn't find any visual changes. Let's keep checking in on follow-ups and tweak it if needed 🚀
Thanks, Mikael 🙇♂️
Follow-up to #50502, which removed token fallbacks for routes.
This removes fallbacks from components used within premium analytics route, but that aren't under routes folder directly.
No big difference in output bundles; the fallbacks were previously added manually, now they're just added as part of the build process:
8 incorrect manual fallback values removed — since wpds var was used already, these should not have actual affect on UI:
--wpds-border-radius-md8px4px--wpds-border-width-focus1.5pxvar(--wp-admin-border-width-focus, 2px)--wpds-color-foreground-content-neutral-weak#646970,#757575,currentColor#707070--wpds-color-stroke-surface-neutral-weak#e0e0e0#f0f0f0(theme)--wpds-dimension-gap-md16px12px--wpds-typography-font-weight-medium500499Proposed changes
projects/packages/premium-analytics/packages/icons/*); linter ignores them, and they'd need a different solution.Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions