wp-build-polyfills: strip minified sourcemaps from production builds#50734
Draft
louwie17 wants to merge 1 commit into
Draft
wp-build-polyfills: strip minified sourcemaps from production builds#50734louwie17 wants to merge 1 commit into
louwie17 wants to merge 1 commit into
Conversation
wp-build hardcodes sourcemap: true for package bundles (build/modules/** and build/scripts/**), so *.min.js.map files (~11 MiB for Premium Analytics) shipped to every production mirror via the build/** production-include. Extend strip-unminified-prod to delete *.min.js.map / *.min.css.map under its target subdirs and strip the trailing sourceMappingURL comment from each minified asset so browsers don't request the deleted map. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QCScbQabawavV9iSNFpZhE
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we will go ahead with this yet, as it would mean that SCRIPT_DEBUG=true is of no use
Proposed changes
@wordpress/build(wp-build) hardcodessourcemap: truefor package bundles, so every production build emits*.min.js.mapfiles underbuild/modules/**andbuild/scripts/**. Since the wholebuild/**tree isproduction-include, those maps ship to the package mirror and into consumer plugin zips — ~11 MiB for Premium Analytics today (e.g.build/modules/ui/index.min.js.mapalone is 3.2 MiB). Widget and route bundles get no sourcemaps at all, so the maps that do ship are inconsistent dead weight. (No upstream toggle exists yet; nearest analogs are WordPress/gutenberg#75395 and WordPress/gutenberg#75993.)strip-unminified-prodinwp-build-polyfillsto also delete*.min.js.map/*.min.css.mapunder its target subdirs (routes,scripts,modules,styles,widgets).sourceMappingURLcomment from each minified asset whose map was deleted, so browsers don't request a 404'd map.strip()'s return value (deletedMaps).Related product discussion/links
--no-script-debugflag), Build: Skip sourcemaps for WASM-inlined script module workers WordPress/gutenberg#75993 (sourcemaps disabled for WASM workers for the same size reason)Does this pull request change what data or activity we track or use?
No.
Testing instructions
cd projects/packages/wp-build-polyfills && pnpm run build && pnpm run test— all tests pass, includingstrip-unminified-prod-real-fixture.test.jswhich builds a real wp-build fixture and asserts the.min.js.mapfiles are removed and theirsourceMappingURLreferences stripped.cd projects/packages/premium-analytics && pnpm run build-production, then confirmfind build -name '*.map'returns nothing andgrep -r sourceMappingURL build --include='*.min.js'finds no references (the summary line reportsremoved ... 8 minified sourcemap(s))..min.jsas before; only the map files and their references are gone).