Skip to content

Premium Analytics: remove the Videos report performance chart#50801

Draft
Nikschavan wants to merge 2 commits into
trunkfrom
codex/remove-report-performance-chart-videos
Draft

Premium Analytics: remove the Videos report performance chart#50801
Nikschavan wants to merge 2 commits into
trunkfrom
codex/remove-report-performance-chart-videos

Conversation

@Nikschavan

Copy link
Copy Markdown
Member

Fixes #

Proposed changes

  • Remove the performance chart and its chart-only aggregation from the Videos report.
  • Show comparison changes for Plays and Impressions in the records table when report comparison is enabled.
  • Preserve video-detail links by enriching complete-stats rows from the primary daily response.

Related product discussion/links

  • None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Build Premium Analytics and its dependencies with fnm exec --using=24.15.0 pnpm jetpack build plugins/premium-analytics --deps.
  • Open Premium Analytics and navigate to the Videos report.
  • Select a date range without comparison and verify the records table shows video titles, Plays, and Impressions without a performance chart or comparison deltas.
  • Enable date comparison and verify matching videos show change values for both Plays and Impressions.
  • Verify linked video titles still open their video detail pages with the selected date window.
  • Automated verification completed: 24 focused Jest tests, ESLint, Prettier, package typecheck, package build, and the full dependency-stack build.

@Nikschavan Nikschavan added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Package] Premium Analytics labels Jul 24, 2026
@Nikschavan Nikschavan self-assigned this Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the codex/remove-report-performance-chart-videos branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin codex/remove-report-performance-chart-videos

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@Nikschavan
Nikschavan force-pushed the codex/remove-report-performance-chart-videos branch from e547004 to 37620ed Compare July 24, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Premium Analytics [Status] In Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant