Social: add the platform-specific input step to the new connection flow#50804
Open
manzoorwanijk wants to merge 1 commit into
Open
Social: add the platform-specific input step to the new connection flow#50804manzoorwanijk wants to merge 1 commit into
manzoorwanijk wants to merge 1 commit into
Conversation
Extracts the connect-input validation out of use-request-access into a shared, notice-free helper, then builds the platform-input step on top of it: Mastodon and Bluesky credential fields, Submit gated on validity, and duplicate-account errors rendered inline instead of as global notices. Entered values are held in the store so stepping back to the picker and returning does not wipe them.
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
[Feature] Publicize
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
manzoorwanijk
added
[Status] Needs Team Review
manzoorwanijk
marked this pull request as ready for review
July 24, 2026 11:44
Code Coverage SummaryCoverage changed in 9 files. Only the first 5 are listed here.
4 files are newly checked for coverage.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOCIAL-531
Proposed changes
use-request-access.tsintoconnect-input-validation.ts: notice-free, returning{ values, error }so both the legacy connect form (global notice) and the new flow (inline error, gated Submit) share them.use-request-accesskeeps its existing behaviour.platform-inputstep: intro copy, Mastodon handle / Bluesky handle + app password fields, footer with Cancel and Submit. Submit stays disabled until the input is valid; duplicate-account errors render inline in the step.useRequestAccess()and advances toauthorizingonly once the connect popup actually opened.goToNextStep, plusconnectionFlow.inputsso entered values survive stepping back to the picker and returning. Cleared when the flow starts or is cancelled.The legacy accordion (
custom-inputs.tsx) is untouched — it keeps its own markup until the flag ships.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Add the
social-admin-ui-v2blog sticker to the site to enable the feature flag, then go to Jetpack → Social and click Add account.@username@mastodon.socialand the helper text below it. Submit is disabled.foo) — Submit stays disabled. Type@user@mastodon.social— Submit enables.foo.bar.bsky.socialshows the "cannot contain dots" guidance.authorizing, whose UI lands in M2-03.