Skip to content

Cl/note preimage - #101

Merged
charlielye merged 18 commits into
masterfrom
cl/note_preimage
Mar 28, 2023
Merged

Cl/note preimage#101
charlielye merged 18 commits into
masterfrom
cl/note_preimage

Conversation

@charlielye

@charlielye charlielye commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Description

Improve fields.
Don't clean before some builds (need to fix this everywhere).
Can encrypt and decrypt a note preimage.
Grumpkin and aes to bb.js.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when ready

@charlielye
charlielye merged commit b8e88a9 into master Mar 28, 2023
@charlielye
charlielye deleted the cl/note_preimage branch March 28, 2023 21:17
ludamad added a commit that referenced this pull request Apr 14, 2023
* chore: add workspace

* chore: circuits c++ config

* Bump bb

* chore: bump bb

* fix: crs timeout
ludamad added a commit that referenced this pull request Apr 17, 2023
* chore: add workspace

* chore: circuits c++ config

* Bump bb

* chore: bump bb

* fix: crs timeout
ludamad added a commit that referenced this pull request Apr 17, 2023
* chore: add workspace

* chore: circuits c++ config

* Bump bb

* chore: bump bb

* fix: crs timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants