refactor(pxe): migrate CapsuleStore to BaseStagingStore (backport of aztec-labs-eng/aztec-node#101) - #25409
Open
nventuro wants to merge 1 commit into
Conversation
* refactor(pxe): migrate CapsuleStore to BaseStagingStore * refactor(pxe): split capsule store change set ops by DB access * refactor(pxe): address capsule store review feedback (cherry picked from commit ff9545903b2592201515ff7d3af9e92587f15b6e)
nchamo
approved these changes
Sep 4, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was unmerged and was not in the queue
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of aztec-labs-eng/aztec-node#101 to the v5 line: a
git cherry-pick -xof its squash commit onaztec-node/main,ff9545903b2592201515ff7d3af9e92587f15b6e. The change itself was described and reviewed there; this PR is only about the port being faithful, so please review it as such.Validating the backport
Fetch the source repo once:
git remote add node https://github.com/aztec-labs-eng/aztec-node && git fetch node main.Compare the upstream patch with this PR's patch (
range-diffcompares patches, so unrelated histories are fine):Expected: the
(cherry picked from commit …)trailer and exactly one patch-level difference, inyarn-project/pxe/src/storage/capsule_store/capsule_store.ts:Same added import on both sides; the scope differs because upstream renamed its packages to
@aztec-labs/*(chore: publish labs packages under the @aztec-labs npm scope aztec-labs-eng/aztec-node#93) and this repo keeps@aztec/*. Surrounding import lines show as context-only differences (single-/+followed by a space) for the same reason. No other file differs.Build and run the unit suites at this commit (from
yarn-project/):yarn workspace @aztec/pxe build && yarn workspace @aztec/txe build && yarn workspace @aztec/pxe test && yarn workspace @aztec/txe test. The upstream PR's own tests are part of these suites, so passing them is the behavioral check; CI on this PR runs them as well.Confirm upstream's package-scope renames leaked nothing into this repo:
git grep -cE '@aztec-labs|@aztec-foundation' -- yarn-projecton this PR's head must return no matches.Stack
Stacked on the backport of aztec-labs-eng/aztec-node#98 (branch
nico/port-node-98-fact-store-staging, PR #25368); to be rebased ontomerge-train/fairies-v5once that one merges. Order: #20 → #35 → #40 → #47 → #94 → #100 → #98 → #101 → #108 → #110 (aztec-node numbers).