refactor(pxe): migrate SenderTaggingStore to BaseStagingStore (backport of aztec-labs-eng/aztec-node#108) - #25410
Open
nventuro wants to merge 1 commit into
Conversation
* refactor(pxe): migrate SenderTaggingStore to BaseStagingStore * refactor(pxe): pass all staged stores to the synchronizer * refactor(pxe): drop the staged store list comment * refactor(pxe): inline the sender tagging changeset writers (cherry picked from commit 35e6bf053f418f5aa2a484387e0219b3588565fc)
nchamo
approved these changes
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was unmerged and was not in the queue
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of aztec-labs-eng/aztec-node#108 to the v5 line: a
git cherry-pick -xof its squash commit onaztec-node/main,35e6bf053f418f5aa2a484387e0219b3588565fc. The change itself was described and reviewed there; this PR is only about the port being faithful, so please review it as such.Validating the backport
Fetch the source repo once:
git remote add node https://github.com/aztec-labs-eng/aztec-node && git fetch node main.Compare the upstream patch with this PR's patch (
range-diffcompares patches, so unrelated histories are fine):Expected: only the
(cherry picked from commit …)trailer as a patch-level difference — the pick applied without conflicts and was not edited. Any single-prefix-/+lines are context-only differences from upstream's@aztec-labs/*package-scope rename (chore: publish labs packages under the @aztec-labs npm scope aztec-labs-eng/aztec-node#93), which this repo does not take.Build and run the unit suites at this commit (from
yarn-project/):yarn workspace @aztec/pxe build && yarn workspace @aztec/txe build && yarn workspace @aztec/pxe test && yarn workspace @aztec/txe test. The upstream PR's own tests are part of these suites, so passing them is the behavioral check; CI on this PR runs them as well.Confirm upstream's package-scope renames leaked nothing into this repo:
git grep -cE '@aztec-labs|@aztec-foundation' -- yarn-projecton this PR's head must return no matches.Stack
Stacked on the backport of aztec-labs-eng/aztec-node#101 (branch
nico/port-node-101-capsule-store-staging); to be rebased ontomerge-train/fairies-v5once that one merges. Order: #20 → #35 → #40 → #47 → #94 → #100 → #98 → #101 → #108 → #110 (aztec-node numbers).