feat: real ACIR simulator with mock ACVM by sirasistant · Pull Request #114 · AztecProtocol/aztec-packages

sirasistant · 2023-03-29T13:57:47Z

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

I have reviewed my diff in github, line by line.
Every change is related to the PR description.
I have linked this pull request to the issue(s) that it resolves.
There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
The branch has been rebased against the head of its merge target.
I'm happy for the PR to be merged at the reviewer's next convenience.

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * feat(base): nullifier tree impl (#119) * chore(bb): update branch * feat: impl nullifier logic * fix(base): naming and miscalculations * fix: update subtree sibling path depth constants * fix: more nits --------- Co-authored-by: cheethas <urmasurda@gmail.com> --------- Co-authored-by: dbanks12 <david@aztecprotocol.com> Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * feat(base): nullifier tree impl (#119) * chore(bb): update branch * feat: impl nullifier logic * fix(base): naming and miscalculations * fix: update subtree sibling path depth constants * fix: more nits --------- Co-authored-by: cheethas <urmasurda@gmail.com> --------- Co-authored-by: dbanks12 <david@aztecprotocol.com> Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * feat(base): nullifier tree impl (#119) * chore(bb): update branch * feat: impl nullifier logic * fix(base): naming and miscalculations * fix: update subtree sibling path depth constants * fix: more nits --------- Co-authored-by: cheethas <urmasurda@gmail.com> --------- Co-authored-by: dbanks12 <david@aztecprotocol.com> Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>

* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>

* implemented keccak hash in stdlib * making some minor naming fixes after rebase --------- Co-authored-by: ledwards2225 <l.edwards.d@gmail.com>

The labs node executes protocol circuits with noir-execute as of aztec-node #114, and no code in this repo ever ran the acvm binary. Stop copying it out of a release and stop putting it in the build cache; the workspace build still produces it, since acvm_cli is one of noir's default-members. labs_fnd_hashes.sh recorded acvm's presence as part of the toolchain identity but not noir-execute's, so two trees differing only in whether the binary labs actually uses is present hashed the same, and a labs cache entry built with it could be reused without it. That check now tracks noir-execute. Also corrects two docs that still pointed at the acvm binary: the gate-counts skill's prerequisites and the dsl README's claim that the sequencer executes raw bytecode through acvm_cli. Finally, scopes color_prefix_test's fifo-leak check to a directory of its own. It counted every fifo in /tmp, so any of the dozens belonging to other jobs appearing inside its before/after window failed it; that is what dequeued this PR twice, with before=45 after=46.

sirasistant added 10 commits March 28, 2023 20:50

feat(acir): wip acir simulator implementation

8ce224d

feat(acir): store preimages commitments and null

d266bb5

Merge branch 'master' into arv/acvm_integration_rebase

ca2be0f

fix: fixed azte caddress rw

55c98bc

fix: aztec address back to one field

e30fc53

test(acir): adding dummy test for acir simulator

6b61894

Merge branch 'master' into arv/acvm_integration_rebase

ef7cb35

fix: simulator interfaces

23ae127

fix: remove old add pending contract

4468d99

chore: add acir-simulator to circleci

d102261

sirasistant requested a review from LeilaWang March 29, 2023 14:16

sirasistant added 6 commits March 29, 2023 14:54

Merge branch 'master' into arv/acvm_integration_rebase

df2b2c0

refactor: update integration interface

3672e59

fix: fix some types from the DB callbacks

9885cfd

chore: update dockerfile

7b26004

chore: updating acir sim dockerfile

7395545

Merge branch 'master' into arv/acvm_integration_rebase

b4914fb

LeilaWang approved these changes Mar 29, 2023

View reviewed changes

LeilaWang merged commit 18b5534 into master Mar 29, 2023

LeilaWang deleted the arv/acvm_integration_rebase branch March 29, 2023 15:58

ludamad pushed a commit that referenced this pull request Jul 14, 2023

implemented keccak hash in stdlib (#114)

48ca40e

* implemented keccak hash in stdlib * making some minor naming fixes after rebase --------- Co-authored-by: ledwards2225 <l.edwards.d@gmail.com>

codygunton pushed a commit that referenced this pull request Jan 23, 2024

implemented keccak hash in stdlib (#114)

05a6102

* implemented keccak hash in stdlib * making some minor naming fixes after rebase --------- Co-authored-by: ledwards2225 <l.edwards.d@gmail.com>

AztecBot mentioned this pull request Mar 13, 2026

PXE sync, note discovery, and reorg resilience #21500

Closed

7 tasks

This was referenced Sep 3, 2026

fix(noir): keep noir-execute in the native build cache #25396

Merged

refactor(noir): drop the acvm binary, nothing consumes it #25397

Merged

Navigation Menu

Uh oh!

feat: real ACIR simulator with mock ACVM - #114

feat: real ACIR simulator with mock ACVM#114
LeilaWang merged 16 commits into
masterfrom
arv/acvm_integration_rebase

sirasistant commented Mar 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sirasistant commented Mar 29, 2023

Description

Checklist:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants