Sequencer integration with base and root rollup circuits - #127
Merged
Conversation
They may break serialization
PhilWindle
marked this pull request as ready for review
March 30, 2023 17:06
ludamad
added a commit
that referenced
this pull request
Apr 14, 2023
* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>
ludamad
added a commit
that referenced
this pull request
Apr 17, 2023
* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>
ludamad
added a commit
that referenced
this pull request
Apr 17, 2023
* add basic contract deployment test for private kernel * chore(base_rollup): scaffold * feat(base_rollup): scaffold * fix(base_rollup): var name changes * feat(base_rollup): historical subtree membership checks * feat(merge_rollup) merge rollup types * clean(merge): clean types and scaffold * refactor(merge): seperate merge and base rollup * fix(base): rename messup * clean(merge): pr review * initial test setup * fix: paths and prints * deleted deps * minor tweaks * fix(merge|base): aggregation object naming issue * fix: change interface of base rollup * fix witness init * fix(ts): update bindings (#108) * refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> * fix(ts): update incorrect constant parity * minor fixes * fix(base): update vk pointer handling (#111) * fix: bb update * fix: update head * fix:(base): remove subtrees from interface (#110) * update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base * update kernel interfaces with sim * fix new kernel interface * fix circuit cbind * Adding tests for base rollup + sha256 (#114) * tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment * private kernel test doing actual proving * feat(base): insert commitments and contracts into end trees (#116) * insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments * fixing base rollup test * fix: Update rollup sha256 input + add test with "meaningful" input (#118) * base test cbind fixed * remove old comment * add cbind tests to base rollup * fix unintentional changes * cbind tests for base rollup with some commented out checks * better dummy kernel * fix: enable asan, fix bug * cbind for dummy kernel * print cleanup --------- Co-authored-by: cheethas <urmasurda@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: ludamad <domuradical@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
* fix: Ensure TBB is optional using OPTIONAL_COMPONENTS * chore: Avoid noisy message when tbb not found
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* fix: Ensure TBB is optional using OPTIONAL_COMPONENTS * chore: Avoid noisy message when tbb not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequencer now calls cbinds to base and root rollup circuit simulations.