Skip to content

fix: bootstrap build circuits - #108

Closed
iAmMichaelConnor wants to merge 5 commits into
masterfrom
mc/bootstrap-build-circuits
Closed

fix: bootstrap build circuits#108
iAmMichaelConnor wants to merge 5 commits into
masterfrom
mc/bootstrap-build-circuits

Conversation

@iAmMichaelConnor

@iAmMichaelConnor iAmMichaelConnor commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Bootstrap wasn't checking for the wasm file, so the symlink was silently not pointing to anything, causing the tests to fail.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@iAmMichaelConnor iAmMichaelConnor changed the title Mc/bootstrap build circuits fix: bootstrap build circuits Mar 28, 2023
spalladino
spalladino reviewed Mar 29, 2023
View reviewed changes
Comment thread bootstrap.sh Outdated
iAmMichaelConnor and others added 2 commits March 30, 2023 23:41
@iAmMichaelConnor @spalladino
Update bootstrap.sh
7299960 
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
@iAmMichaelConnor
Merge branch 'master' into mc/bootstrap-build-circuits
69a68b1
@iAmMichaelConnor

iAmMichaelConnor commented Apr 2, 2023

Copy link
Copy Markdown
Contributor Author

Superseded by #146

ludamad pushed a commit that referenced this pull request Apr 14, 2023
@Maddiaa0 dbanks12
cheethas @LHerskind @dbanks12 @rahul-kothari
feat(base_rollup_circuit): base rollup impl (wip) (#99)
5b275db 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* feat(base): nullifier tree impl (#119)

* chore(bb): update branch

* feat: impl nullifier logic

* fix(base): naming and miscalculations

* fix: update subtree sibling path depth constants

* fix: more nits

---------

Co-authored-by: cheethas <urmasurda@gmail.com>

---------

Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad pushed a commit that referenced this pull request Apr 14, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari
feat: new kernel interface, base rollup cbinds + tests (#115)
8b36f95 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad added a commit that referenced this pull request Apr 14, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari @ludamad
Better dummy kernel, fix base rollup tests (#127)
60a0f84 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

* better dummy kernel

* fix: enable asan, fix bug

* cbind for dummy kernel

* print cleanup

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Co-authored-by: ludamad <domuradical@gmail.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@Maddiaa0 dbanks12
cheethas @LHerskind @dbanks12 @rahul-kothari @ludamad
feat(base_rollup_circuit): base rollup impl (wip) (#99)
2172ee5 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* feat(base): nullifier tree impl (#119)

* chore(bb): update branch

* feat: impl nullifier logic

* fix(base): naming and miscalculations

* fix: update subtree sibling path depth constants

* fix: more nits

---------

Co-authored-by: cheethas <urmasurda@gmail.com>

---------

Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari @ludamad
feat: new kernel interface, base rollup cbinds + tests (#115)
c5e0689 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad added a commit that referenced this pull request Apr 17, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari @ludamad
Better dummy kernel, fix base rollup tests (#127)
84fbb24 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

* better dummy kernel

* fix: enable asan, fix bug

* cbind for dummy kernel

* print cleanup

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Co-authored-by: ludamad <domuradical@gmail.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@Maddiaa0 dbanks12
cheethas @LHerskind @dbanks12 @rahul-kothari @ludamad
feat(base_rollup_circuit): base rollup impl (wip) (#99)
9035a83 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* feat(base): nullifier tree impl (#119)

* chore(bb): update branch

* feat: impl nullifier logic

* fix(base): naming and miscalculations

* fix: update subtree sibling path depth constants

* fix: more nits

---------

Co-authored-by: cheethas <urmasurda@gmail.com>

---------

Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari @ludamad
feat: new kernel interface, base rollup cbinds + tests (#115)
8aa4d16 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
ludamad added a commit that referenced this pull request Apr 17, 2023
@dbanks12 cheethas
@LHerskind @Maddiaa0 @rahul-kothari @ludamad
Better dummy kernel, fix base rollup tests (#127)
9a0fb68 
* add basic contract deployment test for private kernel

* chore(base_rollup): scaffold

* feat(base_rollup): scaffold

* fix(base_rollup): var name changes

* feat(base_rollup): historical subtree membership checks

* feat(merge_rollup) merge rollup types

* clean(merge): clean types and scaffold

* refactor(merge): seperate merge and base rollup

* fix(base): rename messup

* clean(merge): pr review

* initial test setup

* fix: paths and prints

* deleted deps

* minor tweaks

* fix(merge|base): aggregation object naming issue

* fix: change interface of base rollup

* fix witness init

* fix(ts): update bindings (#108)

* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>

* fix(ts): update incorrect constant parity

* minor fixes

* fix(base): update vk pointer handling (#111)

* fix: bb update

* fix: update head

* fix:(base): remove subtrees from interface (#110)

* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base

* update kernel interfaces with sim

* fix new kernel interface

* fix circuit cbind

* Adding tests for base rollup + sha256 (#114)

* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment

* private kernel test doing actual proving

* feat(base): insert commitments and contracts into end trees (#116)

* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments

* fixing base rollup test

* fix: Update rollup sha256 input + add test with "meaningful" input (#118)

* base test cbind fixed

* remove old comment

* add cbind tests to base rollup

* fix unintentional changes

* cbind tests for base rollup with some commented out checks

* better dummy kernel

* fix: enable asan, fix bug

* cbind for dummy kernel

* print cleanup

---------

Co-authored-by: cheethas <urmasurda@gmail.com>
Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
Co-authored-by: ludamad <domuradical@gmail.com>
@iAmMichaelConnor
iAmMichaelConnor deleted the mc/bootstrap-build-circuits branch July 11, 2023 07:57
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@arijitdutta67
Ad/Sumcheck-tests-ver2 (#108)
5fe1763 
* rebasing after PR 179
parent 71bdb62
author arijitdutta67 <arijit.dutta67@gmail.com> 1675079130 +0000
committer arijitdutta67 <arijit.dutta67@gmail.com> 1676621191 +0000

parent 71bdb62
author arijitdutta67 <arijit.dutta67@gmail.com> 1675079130 +0000
committer arijitdutta67 <arijit.dutta67@gmail.com> 1676621123 +0000

normalize poly test is modified

relation tests are modified

manual sumcheck round computation working

round_univariate all zero, debug wip

sumcheck round tests are modified

fixing error

minor fixes

relation tests are modified

sumcheck round tests are modified

sumcheck test modification (wip)

Adrian suggestions are adopted

minor fixes

debug after rebase (wip)

minor fixes

changing relation test (wip)

relation tests are fixed

sumcheck round tests are modified

sumcheck tests are added

rebase debug (wip)

Fixing rebase issue, poly index

commenting out relation tests as lambda function can not capture this

* fixing rebase bugs and typos

* all relation tests are passing except gpc for rand values

* fixing bug in the test

* minor cleanup
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@arijitdutta67
Ad/Sumcheck-tests-ver2 (#108)
d63157c 
* rebasing after PR 179
parent 55e85aa
author arijitdutta67 <arijit.dutta67@gmail.com> 1675079130 +0000
committer arijitdutta67 <arijit.dutta67@gmail.com> 1676621191 +0000

parent 55e85aa
author arijitdutta67 <arijit.dutta67@gmail.com> 1675079130 +0000
committer arijitdutta67 <arijit.dutta67@gmail.com> 1676621123 +0000

normalize poly test is modified

relation tests are modified

manual sumcheck round computation working

round_univariate all zero, debug wip

sumcheck round tests are modified

fixing error

minor fixes

relation tests are modified

sumcheck round tests are modified

sumcheck test modification (wip)

Adrian suggestions are adopted

minor fixes

debug after rebase (wip)

minor fixes

changing relation test (wip)

relation tests are fixed

sumcheck round tests are modified

sumcheck tests are added

rebase debug (wip)

Fixing rebase issue, poly index

commenting out relation tests as lambda function can not capture this

* fixing rebase bugs and typos

* all relation tests are passing except gpc for rand values

* fixing bug in the test

* minor cleanup
@AztecBot AztecBot mentioned this pull request Mar 13, 2026
Closed
5 tasks
This was referenced Sep 4, 2026
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalladino spalladino spalladino left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iAmMichaelConnor @spalladino