Translate CRD <-> CNS #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Templates
Co-authored-by: Patrick Lang <plang@microsoft.com>
* Simply issue template * Use issue template builder * Small improvements * template revision Co-authored-by: Qingchuan Hao <qinhao@microsoft.com>
* Add ipam/pool_test.go & add network/*test.go * add testing ./network/ in Makefile * fix context
* NewRequestController and StartRequestController * Making Start Manager in go routine * Lookup HOSTNAME env var * Adding cnsipaminterface.go * Created requestController interface and implemented updating CRD * fix windows 1903 test apimodel.json (Azure#585) * Avoiding redundant calls into cns by only watching for status updates in reconcile loop, ignoring spec updates in reconcil loop. Also adding ability for updating CRD spec through k8sRequestController methods * fixing comments * Cleaned up code and added more comments * Made client interface for testing purposes and changed structure of files to be less folder-y * Addressed comments from Paul Miller and Wei * Beginning unit tests * Finished unit tests * Fixing pipeline issues * found issue, fixed HOSTNAME environment variable dependency * review changes requested * more review changes * Addressed changes from yesterday's review * Changing makefile line to run correct package * Addressed Matt Long's suggestions Co-authored-by: Mathew Merrick <matmerr@users.noreply.github.com>
neaggarwMS
requested changes
Jul 22, 2020
neaggarwMS
requested changes
Jul 23, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neaggarwMS
reviewed
Jul 24, 2020
neaggarwMS
previously approved these changes
Jul 24, 2020
neaggarwMS
approved these changes
Jul 24, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Translation between CNS and CRD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Translation between CRD and CNS